From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB358C63777 for ; Thu, 19 Nov 2020 22:43:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63D3621D40 for ; Thu, 19 Nov 2020 22:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbgKSWm7 (ORCPT ); Thu, 19 Nov 2020 17:42:59 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:54716 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726614AbgKSWm7 (ORCPT ); Thu, 19 Nov 2020 17:42:59 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 95BCD1C0BA2; Thu, 19 Nov 2020 23:42:56 +0100 (CET) Date: Thu, 19 Nov 2020 23:42:56 +0100 From: Pavel Machek To: Scott Branden Cc: Arnd Bergmann , Greg Kroah-Hartman , Desmond Yan , Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Olof Johansson Subject: Re: [PATCH v7 02/13] misc: bcm-vk: add Broadcom VK driver Message-ID: <20201119224256.GA16032@duo.ucw.cz> References: <20201117232320.4958-1-scott.branden@broadcom.com> <20201117232320.4958-3-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <20201117232320.4958-3-scott.branden@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Add initial version of Broadcom VK driver to enumerate PCI device IDs > of Valkyrie and Viper device IDs. >=20 > VK based cards provide real-time high performance, high throughput, > low latency offload compute engine operations. > They are used for multiple parallel offload tasks as: > audio, video and image processing and crypto operations. >=20 > Further commits add additional features to driver beyond probe/remove. >=20 > Signed-off-by: Scott Branden > +++ b/drivers/misc/bcm-vk/Kconfig > @@ -0,0 +1,15 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Broadcom VK device > +# > +config BCM_VK > + tristate "Support for Broadcom VK Accelerators" > + depends on PCI_MSI > + help > + Select this option to enable support for Broadcom > + VK Accelerators. VK is used for performing > + specific offload processing. > + This driver enables userspace programs to access these > + accelerators via /dev/bcm-vk.N devices. > + > + If unsure, say N. Could we a) align the text the usual way b) explain what the VK is here? What kind of offloads does it do? What does "VK" mean? c) explain where such accelerators might be found. (Is remoteproc framework unusable for this?) Thanks, Pavel --=20 http://www.livejournal.com/~pavelmachek --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX7b08AAKCRAw5/Bqldv6 8sUPAKCpXNCUGytbE4HxieK989H9WXCQ6gCgwXNSMofODhkvkPGnBie/ycqIFkQ= =nxou -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--