mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Waiman Long' <longman@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Phil Auld <pauld@redhat.com>
Subject: Re: [RFC PATCH 5/5] locking/rwsem: Remove reader optimistic spinning
Date: Fri, 20 Nov 2020 13:38:28 -0800	[thread overview]
Message-ID: <20201120213828.n7f23qy75hduommo@linux-p48b.lan> (raw)
In-Reply-To: <5fe76531782f4a8492b341d5f381147b@AcuMS.aculab.com>

On Fri, 20 Nov 2020, David Laight wrote:
>I got massive performance improvements from changing a driver
>we have to use mutex instead of the old semaphores (the driver
>was written a long time ago).
>
>While these weren't 'rw' the same issue will apply.
>
>The problem was that the semaphore/mutex was typically only held over
>a few instructions (eg to add an item to a list).
>But with semaphore if you got contention the process always slept.
>OTOH mutex spin 'for a while' before sleeping so the code rarely slept.

The caveat here is if you are using trylock/unlock from irq, which
is the only reason why regular semaphores are still around today. If
not, indeed a mutex is better.

Thanks,
Davidlohr

  parent reply	other threads:[~2020-11-20 22:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18  3:04 [PATCH 0/5] locking/rwsem: Rework " Waiman Long
2020-11-18  3:04 ` [PATCH 1/5] locking/rwsem: Pass the current atomic count to rwsem_down_read_slowpath() Waiman Long
2020-11-18  3:04 ` [PATCH 2/5] locking/rwsem: Prevent potential lock starvation Waiman Long
2020-11-20 14:44   ` Peter Zijlstra
2020-11-20 17:27     ` Waiman Long
2020-11-18  3:04 ` [PATCH 3/5] locking/rwsem: Enable reader optimistic lock stealing Waiman Long
2020-11-20 14:36   ` Peter Zijlstra
2020-11-20 17:26     ` Waiman Long
2020-12-08  3:53   ` Davidlohr Bueso
2020-11-18  3:04 ` [PATCH 4/5] locking/rwsem: Wake up all waiting readers if RWSEM_WAKE_READ_OWNED Waiman Long
2020-11-18  4:53   ` Davidlohr Bueso
2020-11-19 18:37     ` Waiman Long
2020-11-18  3:04 ` [RFC PATCH 5/5] locking/rwsem: Remove reader optimistic spinning Waiman Long
2020-11-18  5:35   ` Davidlohr Bueso
2020-11-19 18:40     ` Waiman Long
2020-11-20 13:11       ` David Laight
2020-11-20 17:04         ` Waiman Long
2020-11-20 17:37           ` David Laight
2020-11-20 21:38         ` Davidlohr Bueso [this message]
2020-11-21 11:50           ` David Laight
2020-11-20 14:44     ` Peter Zijlstra
2020-11-20 22:39       ` Waiman Long
2020-11-20 14:42   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120213828.n7f23qy75hduommo@linux-p48b.lan \
    --to=dave@stgolabs.net \
    --cc=David.Laight@ACULAB.COM \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®