From: Mark Brown <broonie@kernel.org>
To: Philippe Duplessis-Guindon <pduplessis@efficios.com>
Cc: linux-trace-devel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] regmap: remove duplicate `type` field from `regcache_sync` trace event
Date: Mon, 23 Nov 2020 18:10:38 +0000 [thread overview]
Message-ID: <20201123181038.GN6322@sirena.org.uk> (raw)
In-Reply-To: <20201123161519.4643-1-pduplessis@efficios.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Mon, Nov 23, 2020 at 11:15:19AM -0500, Philippe Duplessis-Guindon wrote:
> $ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
> name: regcache_sync
> ID: 1216
> format:
These dumps are very large, don't fit within 80 columns and it's quite
hard to figure out information they are intended to convey so they make
it quite hard to read your commit message. Please just remove them if
they can't be made clear, I think the text is enough.
> field:__data_loc char[] type; offset:16; size:4; signed:1;
> field:int type; offset:20; size:4; signed:1;
> Erase the `int field` type, who was not assigned. This field was introduce by mistake and this commit removes it.
Please word wrap your commit message at less than 80 columns.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-23 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 16:15 Philippe Duplessis-Guindon
2020-11-23 16:39 ` Mathieu Desnoyers
2020-11-23 18:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123181038.GN6322@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=pduplessis@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®