From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49795C63777 for ; Tue, 24 Nov 2020 17:20:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFCE0205CA for ; Tue, 24 Nov 2020 17:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=mntre.com header.i=@mntre.com header.b="dixofOlg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390680AbgKXRUm (ORCPT ); Tue, 24 Nov 2020 12:20:42 -0500 Received: from softboy.mntmn.com ([91.250.115.15]:59012 "EHLO softboy.mntmn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390140AbgKXRUl (ORCPT ); Tue, 24 Nov 2020 12:20:41 -0500 X-Greylist: delayed 470 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Nov 2020 12:20:40 EST From: "Lukas F. Hartmann" DKIM-Filter: OpenDKIM Filter v2.11.0 softboy.mntmn.com 5B16A720718 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mntre.com; s=mntremail; t=1606237969; bh=UEu8QDWrOSRJQOojTYBi65+7G2OU5JZ5f4MfrL5efs4=; h=From:To:Cc:Subject:Date:From; b=dixofOlgFN3BMeNmGaGzbvnWgAxoJfqMfxmQGjJlXm6NW6rNfIzUI0nUj1mVJoOpI s6Dui+LI4tSjA2/O6aQ5BEUoQ+nmtC29fz3yrj8ZGQB8iuHHEf8kBeCefUIdoGGuuk QgpYOEPaNk8WJ7vTtpuHL/OjHjz6HX4pn9iqlrKDxGBHsT2zBZ/87uMHrad0yEgMEe BQ+sxgKnumrAuomnP97wG3hRT3PS/dR/5pwr9WdPPfMudy04jRhYg78amxfZvwlwK0 JVQu4qxE1Kb990gFE09o7bwA1LzzqL8Y4F1gyM+6z2X4asoVAEMdTuErwflzz8XaGE ubx5BaDwVnmkg== To: lukas@mntre.com Cc: agx@sigxcpu.org, laurentiu.palcu@nxp.com, Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: nwl-dsi: fixup mode only for LCDIF input, not DCSS Date: Tue, 24 Nov 2020 18:12:17 +0100 Message-Id: <20201124171216.980628-1-lukas@mntre.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fixup of HSYNC and VSYNC should not be done when the input source is DCSS, or internal display does not work on MNT Reform 2 (open hardware laptop based on NXP i.MX8M using DCSS->DSI->eDP for internal display). Signed-off-by: Lukas F. Hartmann --- drivers/gpu/drm/bridge/nwl-dsi.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 66b67402f..6735ab2a2 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -807,10 +807,16 @@ static bool nwl_dsi_bridge_mode_fixup(struct drm_bridge *bridge, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) { - /* At least LCDIF + NWL needs active high sync */ - adjusted_mode->flags |= (DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); - adjusted_mode->flags &= ~(DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + struct device_node *remote; + struct nwl_dsi *dsi = bridge_to_dsi(bridge); + + remote = of_graph_get_remote_node(dsi->dev->of_node, 0, + NWL_DSI_ENDPOINT_LCDIF); + if (remote) { + /* At least LCDIF + NWL needs active high sync */ + adjusted_mode->flags |= (DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); + adjusted_mode->flags &= ~(DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); + } return true; } -- 2.28.0