From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269FBC2D0E4 for ; Tue, 24 Nov 2020 19:21:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8B782087C for ; Tue, 24 Nov 2020 19:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391001AbgKXTVR (ORCPT ); Tue, 24 Nov 2020 14:21:17 -0500 Received: from mga02.intel.com ([134.134.136.20]:6100 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390919AbgKXTVQ (ORCPT ); Tue, 24 Nov 2020 14:21:16 -0500 IronPort-SDR: pS9IGid3UMhq7vQjDQySwdi7mA/+ewaLa+aFtTQ0QpjRbB2tRXkEu1RHAvd75seP2Q7exG86yG +XZcn+yUHbCg== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="159047623" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="159047623" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:21:14 -0800 IronPort-SDR: OLNL98UQqTjBcLDUXxkbsVgEdVfu7E4xZ239WXHSDV8ctQuGRixvVjwDyVnTWnRymaMZHSDKY/ 55TSGREREBhQ== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="478606996" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:21:14 -0800 Date: Tue, 24 Nov 2020 11:21:13 -0800 From: Ira Weiny To: Matthew Wilcox Cc: Andrew Morton , Dave Hansen , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Thomas Gleixner , Luis Chamberlain , Patrik Jakobsson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Howells , Chris Mason , Josef Bacik , David Sterba , Steve French , Jaegeuk Kim , Chao Yu , Nicolas Pitre , "Martin K. Petersen" , Brian King , Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Kirti Wankhede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/17] mm/highmem: Lift memcpy_[to|from]_page and memset_page to core Message-ID: <20201124192113.GL1161629@iweiny-DESK2.sc.intel.com> References: <20201124060755.1405602-1-ira.weiny@intel.com> <20201124060755.1405602-2-ira.weiny@intel.com> <20201124141941.GB4327@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124141941.GB4327@casper.infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 02:19:41PM +0000, Matthew Wilcox wrote: > On Mon, Nov 23, 2020 at 10:07:39PM -0800, ira.weiny@intel.com wrote: > > +static inline void memzero_page(struct page *page, size_t offset, size_t len) > > +{ > > + memset_page(page, 0, offset, len); > > +} > > This is a less-capable zero_user_segments(). Actually it is a duplicate of zero_user()... Sorry I did not notice those... :-( Why are they called '_user_'? Ira