From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD9BC2D0E4 for ; Tue, 24 Nov 2020 19:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AEC220B1F for ; Tue, 24 Nov 2020 19:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404326AbgKXTZK (ORCPT ); Tue, 24 Nov 2020 14:25:10 -0500 Received: from mga18.intel.com ([134.134.136.126]:17772 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390987AbgKXTZJ (ORCPT ); Tue, 24 Nov 2020 14:25:09 -0500 IronPort-SDR: tK38+FhMbwAc+WFE+pw/hXCe1iX6ZqDIMWUzyP/RpaOOaVYp6lwGcudAr69P5PbMRfcd6hgZIc Mhas4PmUaw6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="159771502" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="159771502" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:25:08 -0800 IronPort-SDR: 6Sl8+oaY1IVjYtT30cuSTX9tyV+kga+JlcAgTnvahVIiQy/tyDZShM5V7oiCOTFgkHLbC+8Y3I MHdmSzM7LTFQ== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="478608510" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 11:25:08 -0800 Date: Tue, 24 Nov 2020 11:25:08 -0800 From: Ira Weiny To: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Thomas Gleixner , Dave Hansen , Matthew Wilcox , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Luis Chamberlain , Patrik Jakobsson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Howells , Steve French , Jaegeuk Kim , Chao Yu , Nicolas Pitre , "Martin K. Petersen" , Brian King , Greg Kroah-Hartman , Alexei Starovoitov , Daniel Borkmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Kirti Wankhede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/17] fs/btrfs: Convert to memzero_page() Message-ID: <20201124192508.GM1161629@iweiny-DESK2.sc.intel.com> References: <20201124060755.1405602-1-ira.weiny@intel.com> <20201124060755.1405602-6-ira.weiny@intel.com> <20201124141244.GE17322@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124141244.GE17322@twin.jikos.cz> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 03:12:44PM +0100, David Sterba wrote: > On Mon, Nov 23, 2020 at 10:07:43PM -0800, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > Remove the kmap/memset()/kunmap pattern and use the new memzero_page() > > call where possible. > > > > Cc: Chris Mason > > Cc: Josef Bacik > > Cc: David Sterba > > Signed-off-by: Ira Weiny > > --- > > fs/btrfs/inode.c | 21 +++++---------------- > > The patch converts the pattern only in inode.c, but there's more in > compression.c, extent_io.c, zlib.c,d zstd.c (kmap_atomic) and reflink.c, > send.c (kmap). Thanks... not sure how I missed reflink.c and send.c. I'll add them in v2. Thanks! Ira