From: Mark Rutland <mark.rutland@arm.com>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will@kernel.org, matthias.bgg@gmail.com,
linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com
Subject: Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION
Date: Wed, 25 Nov 2020 10:36:37 +0000 [thread overview]
Message-ID: <20201125103637.GC70906@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20201124090131.27257-1-lecopzer.chen@mediatek.com>
On Tue, Nov 24, 2020 at 05:01:31PM +0800, Lecopzer Chen wrote:
> From: "Lecopzer Chen" <lecopzer.chen@mediatek.com>
>
> Although most of modern devices use ACPI, there still has combination
> of APM + ARM64.
>
> In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION
> default is y if ACPI isn't configured.
I'm a bit confused why this should be enabled for !ACPI. Which DT
platforms need this, and how do they use it? Why should this only be
enabled for kernels without ACPI support, and not for kernels that
support both ACPI and DT?
Thanks,
Mark.
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Suggested-by: YJ Chiang <yj.chiang@mediatek.com>
> ---
> arch/arm64/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1515f6f153a0..5e9e3694015a 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -260,6 +260,9 @@ config NO_IOPORT_MAP
> config STACKTRACE_SUPPORT
> def_bool y
>
> +config SYS_SUPPORTS_APM_EMULATION
> + def_bool y if !ACPI
> +
> config ILLEGAL_POINTER_VALUE
> hex
> default 0xdead000000000000
> --
> 2.18.0
>
next prev parent reply other threads:[~2020-11-25 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:01 Lecopzer Chen
2020-11-25 10:36 ` Mark Rutland [this message]
2020-11-25 11:41 ` Lecopzer Chen
2020-12-16 15:58 ` Catalin Marinas
2020-12-16 16:41 ` Lecopzer Chen
2020-12-17 16:49 ` Catalin Marinas
2020-12-18 5:02 ` Lecopzer Chen
2020-12-14 9:28 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125103637.GC70906@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=will@kernel.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®