From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E01C64E90 for ; Mon, 30 Nov 2020 09:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ABFB20825 for ; Mon, 30 Nov 2020 09:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgK3Jer (ORCPT ); Mon, 30 Nov 2020 04:34:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:34590 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbgK3Jeq (ORCPT ); Mon, 30 Nov 2020 04:34:46 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1074EAC6A; Mon, 30 Nov 2020 09:34:05 +0000 (UTC) Date: Mon, 30 Nov 2020 10:34:04 +0100 From: Daniel Wagner To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: trix@redhat.com, njavali@marvell.com, jejb@linux.ibm.com, "Martin K . Petersen" , GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition Message-ID: <20201130093404.xjow7bddb5jw3myj@beryllium.lan> References: <20201127182741.2801597-1-trix@redhat.com> <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote: > On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner wrote: > > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \ > > > - atomic_dec(&__qpair->ref_count); \ > > > + atomic_dec(&__qpair->ref_count) \ > > > > Nitpick, please insert an additional tab after the remove so that the > > backlashes align again. > > > > Uhm, if there's no semicolon, then presumably it's the final line of the > macro, and thus there should be no tabs and no backslash at the end of the > line. Right! Didn't realize it. The backslash should be removed.