From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH 2/3] clear_warn_once: bind a timer to written reset value
Date: Mon, 30 Nov 2020 11:20:24 -0500 [thread overview]
Message-ID: <20201130112024.34bcbbd1@gandalf.local.home> (raw)
In-Reply-To: <20201126063029.2030-3-paul.gortmaker@windriver.com>
On Thu, 26 Nov 2020 01:30:28 -0500
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> +++ b/Documentation/admin-guide/clearing-warn-once.rst
> @@ -7,3 +7,12 @@ echo 1 > /sys/kernel/debug/clear_warn_once
>
> clears the state and allows the warnings to print once again.
> This can be useful after test suite runs to reproduce problems.
> +
> +Values greater than one set a timer for a periodic state reset; e.g.
> +
> +echo 3600 > /sys/kernel/debug/clear_warn_once
I wonder if the value should be in minutes and not seconds, otherwise, a
wrong value could possibly DoS the machine, if you were to write 2 into it.
If there were a lot of warnings in high frequency events.
Or is dumping out a bunch of warnings every 2 seconds not be a problem?
Anyway, would there ever be a need to have it cleared in less than 1 minute
intervals?
-- Steve
> +
> +will establish an hourly state reset, effectively turning WARN_ONCE
> +into a long period rate-limited warning.
next prev parent reply other threads:[~2020-11-30 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 6:30 [PATCH 0/3] clear_warn_once: add timed interval resetting Paul Gortmaker
2020-11-26 6:30 ` [PATCH 1/3] clear_warn_once: expand debugfs to include read support Paul Gortmaker
2020-11-26 6:30 ` [PATCH 2/3] clear_warn_once: bind a timer to written reset value Paul Gortmaker
2020-11-30 16:20 ` Steven Rostedt [this message]
2020-11-30 17:17 ` Paul Gortmaker
2020-12-01 3:36 ` Steven Rostedt
2020-11-26 6:30 ` [PATCH 3/3] clear_warn_once: add a warn_once_reset= boot parameter Paul Gortmaker
2020-11-27 16:13 ` [PATCH 0/3] clear_warn_once: add timed interval resetting Petr Mladek
2020-11-27 17:43 ` Paul Gortmaker
2020-12-01 12:59 ` Petr Mladek
2020-11-30 6:02 ` Sergey Senozhatsky
2020-11-30 16:24 ` Steven Rostedt
2020-11-30 3:08 ` Andi Kleen
2020-11-30 17:38 ` Paul Gortmaker
2020-12-01 12:49 ` Petr Mladek
2020-12-01 18:05 ` Paul Gortmaker
2020-12-09 16:37 ` Petr Mladek
2020-12-09 17:21 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130112024.34bcbbd1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ak@linux.intel.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®