From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Luo Jiaxing <luojiaxing@huawei.com>
Cc: bgolaszewski@baylibre.com, linus.walleij@linaro.org,
Sergey.Semin@baikalelectronics.ru, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it
Date: Mon, 30 Nov 2020 13:22:50 +0200 [thread overview]
Message-ID: <20201130112250.GK4077@smile.fi.intel.com> (raw)
In-Reply-To: <1606728979-44259-1-git-send-email-luojiaxing@huawei.com>
On Mon, Nov 30, 2020 at 05:36:19PM +0800, Luo Jiaxing wrote:
> The mask and unmask registers are not configured in dwapb_irq_enable() and
> dwapb_irq_disable(). In the following situations, the IRQ will be masked by
> default after the IRQ is enabled:
>
> mask IRQ -> disable IRQ -> enable IRQ
>
> In this case, the IRQ status of GPIO controller is inconsistent with it's
> irq_data too. For example, in __irq_enable(), IRQD_IRQ_DISABLED and
> IRQD_IRQ_MASKED are both clear, but GPIO controller do not perform unmask.
Sounds a bit like a papering over the issue which is slightly different.
Can you elaborate more, why ->irq_mask() / ->irq_unmask() are not being called?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-30 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 9:36 Luo Jiaxing
2020-11-30 11:22 ` Andy Shevchenko [this message]
2020-12-01 8:59 ` luojiaxing
2020-12-05 22:15 ` Serge Semin
2020-12-06 15:02 ` Linus Walleij
2020-12-06 18:50 ` Marc Zyngier
2020-12-07 13:10 ` luojiaxing
2021-01-06 10:24 ` Bartosz Golaszewski
[not found] ` <CAHp75VcFo2hc1kjP9jLxmCdN79rD2R4vCw2P8UssbWe2v4zwcw@mail.gmail.com>
2021-01-07 12:20 ` Serge Semin
2020-12-07 13:04 ` luojiaxing
2020-12-07 12:44 ` luojiaxing
2020-12-05 21:58 ` Linus Walleij
2023-12-15 8:09 ` Thomas Gleixner
2023-12-15 10:24 ` Serge Semin
2023-12-15 10:56 ` Thomas Gleixner
2023-12-15 12:57 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130112250.GK4077@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luojiaxing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®