From: Mark Brown <broonie@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vkoul@kernel.org,
vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, gregkh@linuxfoundation.org, jank@cadence.com,
srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
mengdong.lin@intel.com, bard.liao@intel.com
Subject: Re: [PATCH 5/5] ASoC/SoundWire: rt711-sdca: Add RT711 SDCA vendor-specific driver
Date: Mon, 30 Nov 2020 18:17:08 +0000 [thread overview]
Message-ID: <20201130181708.GF4756@sirena.org.uk> (raw)
In-Reply-To: <20201103172226.4278-6-yung-chuan.liao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2350 bytes --]
On Wed, Nov 04, 2020 at 01:22:26AM +0800, Bard Liao wrote:
> From: Shuming Fan <shumingf@realtek.com>
>
> This is the initial codec driver for rt711 SDCA version.
This and the rt1316 change are failing to build for me on both the
regmap tree and a merge of this branch into the ASoC tree in an x86
allmodconfig with the errors below, I assume this is a dependency on the
SoundWire tree which I guess I need a pull request for?
/mnt/kernel/sound/soc/codecs/rt1316-sdw.c: In function 'rt1316_read_prop':
/mnt/kernel/sound/soc/codecs/rt1316-sdw.c:83:6: error: 'struct sdw_slave_prop' has no member named 'is_sdca'
prop->is_sdca = true;
^~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c: In function 'rt711_sdca_read_prop':
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:182:6: error: 'struct sdw_slave_prop' has no member named 'is_sdca'
prop->is_sdca = true;
^~
In file included from /mnt/kernel/include/linux/printk.h:409,
from /mnt/kernel/include/linux/kernel.h:16,
from /mnt/kernel/include/linux/delay.h:22,
from /mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:9:
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c: In function 'rt711_sdca_interrupt_callback':
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:245:31: error: 'struct sdw_slave_intr_status' has no member named 'sdca_cascade'
status->control_port, status->sdca_cascade);
^~
/mnt/kernel/include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
/mnt/kernel/include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
/mnt/kernel/include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:243:2: note: in expansion of macro 'dev_dbg'
dev_dbg(&slave->dev,
^~~~~~~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:308:12: error: 'struct sdw_slave_intr_status' has no member named 'sdca_cascade'
if (status->sdca_cascade)
^~
make[4]: *** [/mnt/kernel/scripts/Makefile.build:283: sound/soc/codecs/rt1316-sdw.o] Error 1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-30 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 17:22 [PATCH 0/5] regmap/SoundWire/ASoC: Add SoundWire SDCA support Bard Liao
2020-11-03 17:22 ` [PATCH 1/5] soundwire: SDCA: add helper macro to access controls Bard Liao
2020-11-23 18:44 ` Mark Brown
2020-11-24 8:33 ` Vinod Koul
2020-11-03 17:22 ` [PATCH 2/5] regmap/SoundWire: sdw: add support for SoundWire 1.2 MBQ Bard Liao
2020-11-24 8:36 ` Vinod Koul
2020-11-03 17:22 ` [PATCH 3/5] ASoC/SoundWire: rt715-sdca: First version of rt715 sdw sdca codec driver Bard Liao
2020-11-03 17:22 ` [PATCH 4/5] ASoC/SoundWire: rt1316: Add RT1316 SDCA vendor-specific driver Bard Liao
2020-11-03 17:22 ` [PATCH 5/5] ASoC/SoundWire: rt711-sdca: Add RT711 " Bard Liao
2020-11-30 18:17 ` Mark Brown [this message]
2020-11-30 18:36 ` Pierre-Louis Bossart
2020-11-26 20:05 ` [PATCH 0/5] regmap/SoundWire/ASoC: Add SoundWire SDCA support Mark Brown
2020-11-30 18:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130181708.GF4756@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®