From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC481C64E7A for ; Tue, 1 Dec 2020 03:26:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72B0220705 for ; Tue, 1 Dec 2020 03:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727677AbgLADZ6 (ORCPT ); Mon, 30 Nov 2020 22:25:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:51144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727637AbgLADZ6 (ORCPT ); Mon, 30 Nov 2020 22:25:58 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF23320705; Tue, 1 Dec 2020 03:25:16 +0000 (UTC) Date: Mon, 30 Nov 2020 22:25:14 -0500 From: Steven Rostedt To: Masayoshi Mizuma Cc: Libo Chen , linux-kernel@vger.kernel.org, m.mizuma@jp.fujitsu.com Subject: Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls Message-ID: <20201130222514.0949e3cc@oasis.local.home> In-Reply-To: <20201130013256.oryyz4wxd356n74o@gabell> References: <20201121021243.1532477-1-libo.chen@oracle.com> <20201130013256.oryyz4wxd356n74o@gabell> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Nov 2020 20:32:56 -0500 Masayoshi Mizuma wrote: > On Fri, Nov 20, 2020 at 06:12:43PM -0800, Libo Chen wrote: > > This issue was first noticed when I was testing different kernels on > > Oracle Linux 8 which as Fedora 30+ adopts BLS as default. Even though a > > kernel entry was added successfully and the index of that kernel entry was > > retrieved correctly, ktest still wouldn't reboot the system into > > user-specified kernel. > > > > The bug was spotted in subroutine reboot_to where the if-statement never > > checks for REBOOT_TYPE "grub2bls", therefore the desired entry will not be > > set for the next boot. > > > > Add a check for "grub2bls" so that $grub_reboot $grub_number can > > be run before a reboot if REBOOT_TYPE is "grub2bls" then we can boot to > > the correct kernel. > > > > Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option") > > > > Signed-off-by: Libo Chen > > Thank you for the fix! > I tested the patch with fedora33. It works well. > > Please feel free to add: > > Tested-by: Masayoshi Mizuma > > Thanks. I may push this upstream by the end of the week. -- Steve