mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Brian Gerst <brgerst@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	"Andy Lutomirski" <luto@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Thomas Gleixner" <tglx@linutronix.de>, "Jan Kara" <jack@suse.cz>,
	"Paweł Jasiak" <pawel@jasiak.xyz>
Subject: Re: [PATCH] fanotify: Fix sys_fanotify_mark() on native x86-32
Date: Tue, 1 Dec 2020 10:48:10 +0100	[thread overview]
Message-ID: <20201201094810.GB24488@quack2.suse.cz> (raw)
In-Reply-To: <20201130223059.101286-1-brgerst@gmail.com>

On Mon 30-11-20 17:30:59, Brian Gerst wrote:
> Commit 121b32a58a3a converted native x86-32 which take 64-bit arguments to
> use the compat handlers to allow conversion to passing args via pt_regs.
> sys_fanotify_mark() was however missed, as it has a general compat handler.
> Add a config option that will use the syscall wrapper that takes the split
> args for native 32-bit.
> 
> Reported-by: Paweł Jasiak <pawel@jasiak.xyz>
> Fixes: 121b32a58a3a ("x86/entry/32: Use IA32-specific wrappers for syscalls taking 64-bit arguments")
> Signed-off-by: Brian Gerst <brgerst@gmail.com>

Thanks for the patch! It looks good to me. Feel free to add:

Acked-by: Jan Kara <jack@suse.cz>

I assume you plan to push this via x86 tree given the changes are mostly
there, don't you?

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2020-12-01  9:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 22:30 Brian Gerst
2020-12-01  9:48 ` Jan Kara [this message]
2020-12-01 15:51   ` Borislav Petkov
2020-12-02  9:10     ` Jan Kara
2020-12-01 17:23 ` Andy Lutomirski
2020-12-01 17:34   ` Andy Lutomirski
2020-12-01 19:00     ` Catalin Marinas
2020-12-01 19:10       ` Andy Lutomirski
2020-12-01 19:19     ` Brian Gerst
2020-12-28 12:43 ` [tip: x86/urgent] " tip-bot2 for Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201094810.GB24488@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=pawel@jasiak.xyz \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®