From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4823C64E7B for ; Wed, 2 Dec 2020 14:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 621AE21D7F for ; Wed, 2 Dec 2020 14:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730125AbgLBOPq (ORCPT ); Wed, 2 Dec 2020 09:15:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728942AbgLBOPp (ORCPT ); Wed, 2 Dec 2020 09:15:45 -0500 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFBF9C0613CF for ; Wed, 2 Dec 2020 06:15:05 -0800 (PST) Received: by mail-il1-x141.google.com with SMTP id f5so1643773ilj.9 for ; Wed, 02 Dec 2020 06:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z4tstK0yqPb2/7JG4Zvyh0/BHtCKh0NvGTuUjF86KO8=; b=hi0ZCu9a/qhdCc/pSu+owQ9WlAOD9fALklksTCXzjDJta5mR5asDZqsMf4LYrp1xhk NQVP4eFXo7nt5IOjz5bMVcOMzrgzUKbME0kK4NoTr5itiCUCe3elSS4DjeP1p1pTfYDN sjYXyXVo9JEd49AegFuR50gvoZiYdClbcPKKnEQZaPuOfWwn80kDHS0P/aSbbO5N+Brl i7cfu/14F0wXK1W4oQj33c+ow+rXmmHJSqSgq1wiTYpw4rAa1lX8C7YFxZwCHtbULIV6 2rfvpLhd+okSPKxLXZgfe4qyn0iToCc/TuTZ0MtTdt+utL1M3HVkdr6aNBw/Yfc4Fu7M Bd+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z4tstK0yqPb2/7JG4Zvyh0/BHtCKh0NvGTuUjF86KO8=; b=e380DJ7rZYRfrAlWFJJ6DeQubYeq0rod0MBDeSyBNq6xi6AzYCx4WaQCC4OQB/RGcv RF48q+UhebNZNmu7drs0nYAD10zcZ6S2LwJvffYlH9WM0NW8o4PCB+PpS7IapgBfYiK1 s8Ms7t6VGVU/GiN3gd6EjlxuuEq3Z7tPAy2/Jk++YmAN0CeXbPVUp70cQOHKX47ZDjOd EcrFBDj1+Uw76Ov9wkbD5SwHsgZ9HXbTuNWNkwWFFO72PTaz5FQa6ZlkTwAdE8mMxzWV tuOUJYG0cUSSeTu7/SsoycMPGzwWiRdPZg6vDJyvCJKjKHS6plMecZmDf3+GDtel/S3v XeQw== X-Gm-Message-State: AOAM532viCk2pAf7SOUwhLVgolVElonp3XYok3+X7YpqsuxK5WTouuVw Ngb175/WUvr4HId6PtT+U9AP9Q== X-Google-Smtp-Source: ABdhPJyqpvXdZVu3cyMSHDhHV4Q0ygSPRGs9U4eTo0CySNT0sdCtks1N5D9pZJ1GkPbNPd2JzxOXfQ== X-Received: by 2002:a92:ab02:: with SMTP id v2mr2507769ilh.184.1606918504945; Wed, 02 Dec 2020 06:15:04 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id e18sm1209151ilc.52.2020.12.02.06.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 06:15:04 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: jonathanh@nvidia.com, evgreen@chromium.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb() Date: Wed, 2 Dec 2020 08:15:02 -0600 Message-Id: <20201202141502.21265-1-elder@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jon Hunter reported observing a build bug in the IPA driver: https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef8260e2@nvidia.com The problem is that the QMB0 max read value set for IPA v4.5 (16) is too large to fit in the 4-bit field. The actual value we want is 0, which requests that the hardware use the maximum it is capable of. Reported-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Alex Elder --- v2: Got confirmation that 0 is the desired value to use (with comment). drivers/net/ipa/ipa_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index d0768452c15cf..84bb8ae927252 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -288,7 +288,7 @@ static void ipa_hardware_config_qsb(struct ipa *ipa) max1 = 0; /* PCIe not present */ break; case IPA_VERSION_4_5: - max0 = 16; + max0 = 0; /* No limit (hardware maximum) */ break; } val = u32_encode_bits(max0, GEN_QMB_0_MAX_READS_FMASK); -- 2.20.1