From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2A9C64E7B for ; Wed, 2 Dec 2020 23:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8193A22201 for ; Wed, 2 Dec 2020 23:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729049AbgLBXQi (ORCPT ); Wed, 2 Dec 2020 18:16:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:41760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgLBXQi (ORCPT ); Wed, 2 Dec 2020 18:16:38 -0500 Date: Wed, 2 Dec 2020 15:15:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1606950957; bh=GIxDqD7uyqfqU0/Yhag9Aqk11nRK5ZDPMst72hACnKs=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=oMYRn4E54/4EJ2VENB7SaShDI/g86o6N/JdhUoTDOC5VmHLSl4punLBvaX5v7Euf9 9hGlahpHiYLijD46ROM026BV78121kP/7FN//sdG5r7agDQPf0a7aDgRq5lfOva2yA 2jCVgxmEf0igttv5F9MDtQMS8PwsLuwGfytOqjSI= From: Andrew Morton To: Qian Cai Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/swapfile: Do not sleep with a spin lock held Message-Id: <20201202151556.01077710acf79f6fd2ba8287@linux-foundation.org> In-Reply-To: <20201202151549.10350-1-qcai@redhat.com> References: <20201202151549.10350-1-qcai@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2020 10:15:49 -0500 Qian Cai wrote: > We can't call kvfree() with a spin lock held, so defer it. > Fixes: 873d7bcfd066 ("mm/swapfile.c: use kvzalloc for swap_info_struct allocatio n") Do you think it's worth a cc:stable? IOW, is this known to ever produce a warning? (If not, why did we need 873d7bcfd066??)