From: Patrick Havelange <patrick.havelange@essensium.com>
To: Madalin Bucur <madalin.bucur@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Patrick Havelange <patrick.havelange@essensium.com>
Subject: [PATCH 3/4] net: freescale/fman-mac: remove direct use of __devm_request_region
Date: Wed, 2 Dec 2020 17:15:59 +0100 [thread overview]
Message-ID: <20201202161600.23738-3-patrick.havelange@essensium.com> (raw)
In-Reply-To: <20201202161600.23738-1-patrick.havelange@essensium.com>
Since the main fman driver is no longer reserving the complete fman
memory region, it is no longer needed to use a custom call to
__devm_request_region, so replace it with devm_request_mem_region
Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
---
drivers/net/ethernet/freescale/fman/mac.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 901749a7a318..35ca33335aed 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -690,12 +690,10 @@ static int mac_probe(struct platform_device *_of_dev)
goto _return_of_get_parent;
}
- mac_dev->res = __devm_request_region(dev,
- fman_get_mem_region(priv->fman),
- res.start, resource_size(&res),
- "mac");
+ mac_dev->res = devm_request_mem_region(dev, res.start,
+ resource_size(&res), "mac");
if (!mac_dev->res) {
- dev_err(dev, "__devm_request_mem_region(mac) failed\n");
+ dev_err(dev, "devm_request_mem_region(mac) failed\n");
err = -EBUSY;
goto _return_of_get_parent;
}
--
2.17.1
next prev parent reply other threads:[~2020-12-02 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 16:15 [PATCH 1/4] net: freescale/fman: Split the main resource region reservation Patrick Havelange
2020-12-02 16:15 ` [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region Patrick Havelange
2020-12-03 8:44 ` Madalin Bucur
2020-12-03 13:54 ` Patrick Havelange
2020-12-02 16:15 ` Patrick Havelange [this message]
2020-12-02 16:16 ` [PATCH 4/4] net: freescale/fman: remove fman_get_mem_region Patrick Havelange
2020-12-02 16:49 ` [PATCH 1/4] net: freescale/fman: Split the main resource region reservation Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202161600.23738-3-patrick.havelange@essensium.com \
--to=patrick.havelange@essensium.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®