From: Peter Zijlstra <peterz@infradead.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] intel_idle: build failure on Linux 5.10-rc6
Date: Thu, 3 Dec 2020 11:05:07 +0100 [thread overview]
Message-ID: <20201203100507.GI2414@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CALjTZvYX5opqV4xDcQefE3U1h22E0nkOR7R9WN4pBqrXBmq0Rg@mail.gmail.com>
On Thu, Dec 03, 2020 at 09:23:11AM +0000, Rui Salvaterra wrote:
> Hi, Peter,
>
> I'm sorry to bother you, but commit
> 6e1d2bc675bd57640f5658a4a657ae488db4c204 ("intel_idle: Fix
> intel_idle() vs tracing") broke my build, when CONFIG_ACPI_PROCESSOR
> is disabled (possibly because it selects CONFIG_ACPI_PROCESSOR_IDLE):
>
> drivers/idle/intel_idle.c: In function ‘intel_idle_init_cstates_icpu’:
> drivers/idle/intel_idle.c:1510:7: error: implicit declaration of
> function ‘intel_idle_state_needs_timer_stop’
> [-Werror=implicit-function-declaration]
> 1510 | if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reverting the aforementioned commit fixes it. Config attached. Please
> let me know if you need anything else!
Yeah sorry about that, just queued the build fix.
https://git.kernel.org/tip/4d916140bf28ff027997144ea1bb4299e1536f87
prev parent reply other threads:[~2020-12-03 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 9:23 Rui Salvaterra
2020-12-03 10:05 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203100507.GI2414@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®