mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@arri.de>
To: Vladimir Oltean <olteanv@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Richard Cochran <richardcochran@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
	George McCollister <george.mccollister@gmail.com>,
	Marek Vasut <marex@denx.de>,
	Helmut Grohne <helmut.grohne@intenta.de>,
	Paul Barker <pbarker@konsulko.com>,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	Tristram Ha <Tristram.Ha@microchip.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Christian Eggers <ceggers@arri.de>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH net-next v5 0/9] net: dsa: microchip: PTP support for KSZ956x
Date: Thu, 3 Dec 2020 11:21:08 +0100	[thread overview]
Message-ID: <20201203102117.8995-1-ceggers@arri.de> (raw)

[1]
http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9563R-Data-Sheet-DS00002419D.pdf

Changes from v4  --> v5
------------------------
[8/9]            -  Fix compile error reported by kernel test robot
                    (NET_DSA_TAG_KSZ must select NET_PTP_CLASSIFY)

Changes from v3  --> v4
------------------------
The first 2 patches of v3 have been applied.

[ 5/12]-->[ 3/9] - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
[ 6/12]-->[ 4/9] - s/low active/active low/
                 - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
[ 7/12]-->[ 5/9] - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
[ 9/12]-->[ 7/9] - Remove useless case statement
                 - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
[10/12]-->[ 8/9] - s/low active/active low/
                 - 80 chars per line
                 - Use IEEE 802.1AS mode (to suppress forwarding of PDelay messages)
                 - Enable/disable hardware timestaping at runtime (port_hwtstamp_set)
                 - Use mutex in port_hwtstamp_set
                 - Don't use port specific struct hwtstamp_config
                 - removed #ifdefs from tag_ksz.c
                 - Set port's tx_latency and rx_latency to 0
                 - added include/linux/dsa/ksz_common.h to MAINTAINERS
[11/12]          - removed Patch 11/12 (PPS support)
[12/12]-->[ 9/9] - 80 chars per line
                 - reverse christmas tree
                 - Set default pulse width for perout pulse to 50% (max. 125ms)
                 - reject unsupported flags for perout_request


Changes from v2  --> v3
------------------------
Applied all changes requested by Vladimir Oltean. v3 depends on my other
netdev patches from 2020-11-18:
- net: ptp: introduce common defines for PTP message types
- net: dsa: avoid potential use-after-free error

[1/11]-->[1/12]  - dts: remove " OR BSD-2-Clause" from SPDX-License-Identifier
                 - dts: add "additionalProperties"
                 - dts: remove quotes
[2/11]-->[2/12]  - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
[3/11]           - [Patch removed] (split ksz_common.h)
[4/11]-->[3/12]  - Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
                 - fixed summary
[5/11]-->[4/12]  - Use "interrupts-extended" syntax
[6/11]-->[5+6/12] - Split up patch
                 - style fixes
                 - use GENMASK()
                 - IRQF_ONESHOT|IRQF_SHARED
[7/11]-->[7/12]  - Remove "default n" from Kconfig
                 - use mutex in adjfine()
                 - style fixes
[8/11]-->[8/12]  - Be more verbose in commit message
                 - Rename helper
                 - provide correction instead of t2
                 - simplify location of UDP header
[9/11]-->[9+10/12] - Split up patch
                 - Update commmit messages
                 - don't use OR operator on irqreturn_t
                 - spin_lock_irqsave() --> spin_lock_bh()
                 - style fixes
                 - remove rx_filter cases for DELAY_REQ
                 - use new PTP_MSGTYPE_* defines
                 - inline ksz9477_ptp_should_tstamp()
                 - ksz9477_tstamp_to_clock() --> ksz9477_tstamp_reconstruct()
                 - use shared data in include/linux/net/dsa/ksz_common.h
                 - wait for tx time stamp (within sleepable context)
                 - use boolean for tx time stamp enable
                 - move t2 from correction to tail tag (again)
                 - ...

Changes from RFC --> v2
------------------------
I think that all open questions regarding the RFC version could be solved.
dts: referenced to dsa.yaml
dts: changed node name to "switch" in example
dts: changed "ports" subnode to "ethernet-ports"
ksz_common: support "ethernet-ports" subnode
tag_ksz: fix usage of correction field (32 bit ns + 16 bit sub-ns)
tag_ksz: use cached PTP header from device's .port_txtstamp function
tag_ksz: refactored ksz9477_tstamp_to_clock()
tag_ksz: pdelay_req: only subtract 2 bit seconds from the correction field
tag_ksz: pdelay_resp: don't move (negative) correction to the egress tail tag
ptp_classify: add ptp_onestep_p2p_move_t2_to_correction helper
ksz9477_ptp: removed E2E support (as suggested by Vladimir)
ksz9477_ptp: removed master/slave sysfs attributes (nacked by Richard)
ksz9477_ptp: refactored ksz9477_ptp_port_txtstamp
ksz9477_ptp: removed "pulse" attribute
kconfig: depend on PTP_1588_CLOCK (instead of "imply")



             reply	other threads:[~2020-12-03 10:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 10:21 Christian Eggers [this message]
2020-12-03 10:21 ` [PATCH net-next v5 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property Christian Eggers
2020-12-09 20:09   ` Rob Herring
2020-12-03 10:21 ` [PATCH net-next v5 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init() Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 4/9] net: dsa: microchip: ksz9477: basic interrupt support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 6/9] net: ptp: add helper for one-step P2P clocks Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 8/9] net: dsa: microchip: ksz9477: remaining " Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support Christian Eggers
2020-12-03 14:12   ` Richard Cochran
2020-12-03 15:36     ` Christian Eggers
2020-12-03 15:52       ` Vladimir Oltean
2020-12-03 16:20         ` Christian Eggers
2020-12-04  0:45       ` Richard Cochran
2020-12-04  1:00         ` Vladimir Oltean
2020-12-04  1:18           ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203102117.8995-1-ceggers@arri.de \
    --to=ceggers@arri.de \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=george.mccollister@gmail.com \
    --cc=helmut.grohne@intenta.de \
    --cc=kuba@kernel.org \
    --cc=kurt.kanzenbach@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pbarker@konsulko.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®