mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Michael Walle <michael@walle.cc>
Subject: [PATCH v8 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C
Date: Thu,  3 Dec 2020 17:29:53 +0100	[thread overview]
Message-ID: <20201203162959.29589-2-michael@walle.cc> (raw)
In-Reply-To: <20201203162959.29589-1-michael@walle.cc>

This flash part actually has 4 block protection bits.

Please note, that this patch is just based on information of the
datasheet of the datasheet and wasn't tested.

Reported-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Fixes: 3e0930f109e7 ("mtd: spi-nor: Rework the disabling of block write protection")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
changes since v7:
 - removed Cc: stable
 - added Fixes: tag
 - added note in commit message about not being tested on real hardware

changes since v6:
 - new patch

 drivers/mtd/spi-nor/sst.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
index e0af6d25d573..0ab07624fb73 100644
--- a/drivers/mtd/spi-nor/sst.c
+++ b/drivers/mtd/spi-nor/sst.c
@@ -18,7 +18,8 @@ static const struct flash_info sst_parts[] = {
 			      SECT_4K | SST_WRITE) },
 	{ "sst25vf032b", INFO(0xbf254a, 0, 64 * 1024, 64,
 			      SECT_4K | SST_WRITE) },
-	{ "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128, SECT_4K) },
+	{ "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128,
+			      SECT_4K | SPI_NOR_4BIT_BP) },
 	{ "sst25wf512",  INFO(0xbf2501, 0, 64 * 1024,  1,
 			      SECT_4K | SST_WRITE) },
 	{ "sst25wf010",  INFO(0xbf2502, 0, 64 * 1024,  2,
-- 
2.20.1


  reply	other threads:[~2020-12-03 16:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 16:29 [PATCH v8 0/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-03 16:29 ` Michael Walle [this message]
2020-12-03 16:29 ` [PATCH v8 2/7] mtd: spi-nor: ignore errors in spi_nor_unlock_all() Michael Walle
2020-12-03 16:29 ` [PATCH v8 3/7] mtd: spi-nor: atmel: remove global protection flag Michael Walle
2020-12-03 16:29 ` [PATCH v8 4/7] mtd: spi-nor: sst: " Michael Walle
2020-12-03 16:29 ` [PATCH v8 5/7] mtd: spi-nor: intel: " Michael Walle
2020-12-03 16:29 ` [PATCH v8 6/7] mtd: spi-nor: atmel: fix unlock_all() for AT25FS010/040 Michael Walle
2020-12-03 16:29 ` [PATCH v8 7/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-09 14:36 ` [PATCH v8 0/7] " Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203162959.29589-2-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®