From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1FCC4361B for ; Mon, 7 Dec 2020 10:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A8C523159 for ; Mon, 7 Dec 2020 10:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbgLGKdQ (ORCPT ); Mon, 7 Dec 2020 05:33:16 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:58484 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbgLGKdP (ORCPT ); Mon, 7 Dec 2020 05:33:15 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kmDom-00045N-42; Mon, 07 Dec 2020 10:32:32 +0000 Date: Mon, 7 Dec 2020 11:32:30 +0100 From: Christian Brauner To: Jann Horn Cc: Oleg Nesterov , "Eric W. Biederman" , linux-kernel@vger.kernel.org Subject: Re: [PATCH pidfd] signal: Add missing __user annotation to copy_siginfo_from_user_any Message-ID: <20201207103230.inx52blkask3662j@wittgenstein> References: <20201207000252.138564-1-jannh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201207000252.138564-1-jannh@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 01:02:52AM +0100, Jann Horn wrote: > copy_siginfo_from_user_any() takes a userspace pointer as second > argument; annotate the parameter type accordingly. > > Signed-off-by: Jann Horn > --- > I'm messing around with clang's version of __user annotation checking > and it spotted this issue: > > kernel/signal.c:3759:44: warning: casting to dereferenceable pointer removes 'noderef' attribute [-Wnoderef] > ret = copy_siginfo_from_user_any(&kinfo, info); > ^~~~ > Untracked cast to function pointer at kernel/signal.c:4294:26 > > > Christian, since this is pidfd code, can you take this through your tree? > Or should I send this to akpm (or someone else)? I'm picking it up now. :) Thanks! Christian