From: David Miller <davem@davemloft.net>
To: cengiz@kernel.wtf
Cc: jmaloy@redhat.com, ying.xue@windriver.com, kuba@kernel.org,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tipc: prevent possible null deref of link
Date: Tue, 08 Dec 2020 15:54:54 -0800 (PST) [thread overview]
Message-ID: <20201208.155454.2156057383798260135.davem@davemloft.net> (raw)
In-Reply-To: <20201207081423.67313-1-cengiz@kernel.wtf>
From: Cengiz Can <cengiz@kernel.wtf>
Date: Mon, 7 Dec 2020 11:14:24 +0300
> `tipc_node_apply_property` does a null check on a `tipc_link_entry`
> pointer but also accesses the same pointer out of the null check block.
>
> This triggers a warning on Coverity Static Analyzer because we're
> implying that `e->link` can BE null.
>
> Move "Update MTU for node link entry" line into if block to make sure
> that we're not in a state that `e->link` is null.
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> ---
Applied, thanks.,
prev parent reply other threads:[~2020-12-08 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:14 Cengiz Can
2020-12-08 23:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208.155454.2156057383798260135.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cengiz@kernel.wtf \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®