From: Peter Zijlstra <peterz@infradead.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
keescook@chromium.org
Subject: Re: Are read-only static labels incompatible with kernel modules?
Date: Tue, 8 Dec 2020 13:51:29 +0100 [thread overview]
Message-ID: <20201208125129.GY2414@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAAeHK+xB0cdJxTvLzRRQuKQkStF+1AN179_8RUvDrpjZy+Utyg@mail.gmail.com>
On Mon, Dec 07, 2020 at 09:37:54PM +0100, Andrey Konovalov wrote:
> Hi,
>
> I'm getting a crash when trying to load a module into a kernel that
> uses __ro_after_init static labels, see the crash below. The label is
> defined and initialized in the main kernel binary, and is used in the
> module. Is this not supported?
Clearly not, but also, the whole RO thing never went past the
maintainers (it also seems to be missing a MAINTAINERs entry).
> static_key_set_linked kernel/jump_label.c:368
> jump_label_add_module+0x1ec/0x2dc kernel/jump_label.c:658
> jump_label_module_notify+0x40/0xa4 kernel/jump_label.c:736
This, it needs to modify the key, which is RO, to add a list of sites
from the module.
It could probably be fixed..
prev parent reply other threads:[~2020-12-08 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 20:37 Andrey Konovalov
2020-12-08 12:51 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208125129.GY2414@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®