mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "J. Avila" <elavila@google.com>
Cc: William Mcvicker <willmcvicker@google.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	mingo@redhat.com, John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	Daniel Mentz <danielmentz@google.com>
Subject: Re: Potential Issue in Tracing Ring Buffer
Date: Tue, 8 Dec 2020 15:00:07 -0500	[thread overview]
Message-ID: <20201208150007.2a0176af@gandalf.local.home> (raw)
In-Reply-To: <CAGFReeOOBoWqq-Ksdg6c7phS6KgpnK5em_PNKgnUX844fYsoEg@mail.gmail.com>

On Tue, 8 Dec 2020 11:37:13 -0800
"J. Avila" <elavila@google.com> wrote:

> Hello Steven,
> 
> Thank you once again for all of your support. We saw that you also recently
> merged a change[1] which adds some validation for the timestamps in
> ring_buffer.c. Would you have any recommendations on how to add a more
> lightweight check for time going "backwards" in the timestamps? The idea
> is that we could use this quick test to detect the problem, then run a build
> with your config to dig deeper.

I'm looking at adding a user space kernel selftest to make sure the buffer
never goes backwards[1] (note the code has changed since that posting). You
can see the stand alone code here[2]. But requires downloading and
installing libtraceevent[3] and libtracefs[4].

-- Steve


[1] https://lore.kernel.org/r/20201201160656.7cc6a5e8@gandalf.local.home
[2] http://rostedt.org/code/test-ring-buffer/
[3] https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
[4] https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/

      reply	other threads:[~2020-12-08 20:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 22:39 J. Avila
2020-11-25  0:56 ` Steven Rostedt
2020-11-26  5:52 ` Greg KH
2020-11-26 18:26   ` Steven Rostedt
2020-11-30 14:48     ` Steven Rostedt
2020-11-30 18:13       ` William Mcvicker
2020-12-08 19:37         ` J. Avila
2020-12-08 20:00           ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208150007.2a0176af@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=danielmentz@google.com \
    --cc=elavila@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®