From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E8AC4361B for ; Wed, 9 Dec 2020 20:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9253723D20 for ; Wed, 9 Dec 2020 20:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387731AbgLIU72 (ORCPT ); Wed, 9 Dec 2020 15:59:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:58626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbgLIU7L (ORCPT ); Wed, 9 Dec 2020 15:59:11 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C311123B99; Wed, 9 Dec 2020 20:58:30 +0000 (UTC) Date: Wed, 9 Dec 2020 15:58:28 -0500 From: Steven Rostedt To: Al Viro Cc: LKML , linux-fsdevel@vger.kernel.org Subject: Re: fs/namei.c: Make status likely to be ECHILD in lookup_fast() Message-ID: <20201209155828.7109f8dd@gandalf.local.home> In-Reply-To: <20201209203500.GQ3579531@ZenIV.linux.org.uk> References: <20201209152403.6d6cf9ba@gandalf.local.home> <20201209203500.GQ3579531@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Dec 2020 20:35:00 +0000 Al Viro wrote: > > And most of the d_revalidate() functions have: > > > > if (flags & LOOKUP_RCU) > > return -ECHILD; > > Umm... That depends upon the filesystem mix involved; said that, I'd rather > drop that "unlikely"... Sure enough. I'll send a v2. Thanks, -- Steve