From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA84FC433FE for ; Fri, 11 Dec 2020 11:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8478A23EB1 for ; Fri, 11 Dec 2020 11:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390601AbgLKLwD (ORCPT ); Fri, 11 Dec 2020 06:52:03 -0500 Received: from foss.arm.com ([217.140.110.172]:52376 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbgLKLvp (ORCPT ); Fri, 11 Dec 2020 06:51:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 800B831B; Fri, 11 Dec 2020 03:50:59 -0800 (PST) Received: from bogus (unknown [10.57.54.168]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 271A63F68F; Fri, 11 Dec 2020 03:50:57 -0800 (PST) Date: Fri, 11 Dec 2020 11:50:55 +0000 From: Sudeep Holla To: Alexandre Belloni Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Message-ID: <20201211115055.acoezgrwh45hw6is@bogus> References: <20201211103143.1332302-1-sudeep.holla@arm.com> <20201211114515.GF1781038@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211114515.GF1781038@piout.net> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 12:45:15PM +0100, Alexandre Belloni wrote: > Hello, > > On 11/12/2020 10:31:43+0000, Sudeep Holla wrote: > > Since at91_soc_init is called unconditionally from atmel_soc_device_init, > > we get the following warning on all non AT91 SoCs: > > " AT91: Could not find identification node" > > > > Fix the same by filtering with allowed AT91 SoC list. > > > > Cc: Nicolas Ferre > > Cc: Alexandre Belloni > > Cc: Ludovic Desroches > > Signed-off-by: Sudeep Holla > > --- > > drivers/soc/atmel/soc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > > index c4472b68b7c2..ba9fc07cd91c 100644 > > --- a/drivers/soc/atmel/soc.c > > +++ b/drivers/soc/atmel/soc.c > > @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs) > > return soc_dev; > > } > > > > +static const struct of_device_id at91_soc_allowed_list[] __initconst = { > > + { .compatible = "atmel,at91rm9200", }, > > + { .compatible = "atmel,at91sam9260", }, > > + { .compatible = "atmel,sama5d2", }, > > This is a very small subset of the supported SoCs. a proper list would > be: > > atmel,at91rm9200 > atmel,at91sam9 > atmel,sama5 > atmel,samv7 > Sure I can update it but the existing functions at91_get_cidr_exid_from_chipid and at91_get_cidr_exid_from_dbgu check for following 3 compatibles and bail out if not found: "atmel,at91rm9200-dbgu" "atmel,at91sam9260-dbgu" "atmel,sama5d2-chipid" Quick check on DTS upstream suggested only 3 platforms, hence the choice. -- Regards, Sudeep