mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Qian Cai <qcai@redhat.com>, Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 3/3] driver core: platform: use bus_type functions
Date: Sat, 12 Dec 2020 22:13:48 +0100	[thread overview]
Message-ID: <20201212211348.jnx5sac4nvtb3ic2@pengutronix.de> (raw)
In-Reply-To: <48759bfa-bd21-f28f-043f-7b866d1b7e04@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

Hi Marek,

On Fri, Dec 11, 2020 at 05:12:16PM +0100, Marek Szyprowski wrote:
> On 19.11.2020 13:46, Uwe Kleine-König wrote:
> > +static void platform_shutdown(struct device *_dev)
> > +{
> > +	struct platform_driver *drv = to_platform_driver(_dev->driver);
> > +	struct platform_device *dev = to_platform_device(_dev);
> > +
> > +	if (drv->shutdown)
> > +		drv->shutdown(dev);
> > +}
> 
> This will be called on unbound devices, what causes crash (observed on 
> today's linux-next):
> 
> Will now restart.
> 8<--- cut here ---
> Unable to handle kernel paging request at virtual address fffffff4
> pgd = 289f4b67
> [fffffff4] *pgd=6ffff841, *pte=00000000, *ppte=00000000
> Internal error: Oops: 27 [#1] SMP ARM
> Modules linked in: usb_f_ecm g_ether usb_f_rndis u_ether libcomposite 
> brcmfmac sha256_generic libsha256 sha256_arm cfg80211 brcmutil 
> panel_samsung_s6e8aa0 s5p_csi
> CPU: 0 PID: 1715 Comm: reboot Not tainted 
> 5.10.0-rc7-next-20201211-00069-g1e8aa883315f #9935
> Hardware name: Samsung Exynos (Flattened Device Tree)
> PC is at platform_shutdown+0x8/0x18
> LR is at device_shutdown+0x18c/0x25c
> ...
> Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
> Control: 10c5387d  Table: 4348404a  DAC: 00000051
> Process reboot (pid: 1715, stack limit = 0xd050391e)
> Stack: (0xc3405e60 to 0xc3406000)
> [<c0a38bfc>] (platform_shutdown) from [<c0a34f78>] 
> (device_shutdown+0x18c/0x25c)
> [<c0a34f78>] (device_shutdown) from [<c036d3cc>] (kernel_restart+0xc/0x68)
> [<c036d3cc>] (kernel_restart) from [<c036d680>] 
> (__do_sys_reboot+0x154/0x1f0)
> [<c036d680>] (__do_sys_reboot) from [<c03000c0>] (ret_fast_syscall+0x0/0x58)
> Exception stack(0xc3405fa8 to 0xc3405ff0)
> ...
> ---[ end trace f39e94d5d6fd45bf ]---

Dmitry Baryshkov already proposed a fix, see
https://lore.kernel.org/r/20201212011426.163071-1-dmitry.baryshkov@linaro.org

I expect a v2 soon.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-12-12 21:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 12:46 [PATCH 1/3] driver core: platform: reorder functions Uwe Kleine-König
2020-11-19 12:46 ` [PATCH 2/3] driver core: platform: change logic implementing platform_driver_probe Uwe Kleine-König
2020-11-19 12:46 ` [PATCH 3/3] driver core: platform: use bus_type functions Uwe Kleine-König
     [not found]   ` <CGME20201211161217eucas1p1e66553fbb8d113b417e29150951df683@eucas1p1.samsung.com>
2020-12-11 16:12     ` Marek Szyprowski
2020-12-12 21:13       ` Uwe Kleine-König [this message]
2020-12-11 16:45   ` Qian Cai
2020-12-12  2:01   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201212211348.jnx5sac4nvtb3ic2@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=m.szyprowski@samsung.com \
    --cc=qcai@redhat.com \
    --cc=rafael@kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®