From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH] jump_label: Do not profile branch annotations
Date: Mon, 14 Dec 2020 09:52:06 +0100 [thread overview]
Message-ID: <20201214085206.GW3040@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201211163754.585174b9@gandalf.local.home>
On Fri, Dec 11, 2020 at 04:37:54PM -0500, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> While running my branch profiler that checks for incorrect "likely" and
> "unlikely"s around the kernel, there's a large number of them that are
> incorrect due to being "static_branches".
>
> As static_branches are rather special, as they are likely or unlikely for
> other reasons than normal annotations are used for, there's no reason to
> have them be profiled.
>
> Expose the "unlikely_notrace" and "likely_notrace" so that the
> static_branch can use them, and have them be ignored by the branch
> profilers.
The less that abomination does the better ;-), I'll take it through tip
then?
next prev parent reply other threads:[~2020-12-14 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 21:37 Steven Rostedt
2020-12-14 8:52 ` Peter Zijlstra [this message]
2020-12-14 15:33 ` Steven Rostedt
2021-01-22 14:05 ` [tip: locking/core] " tip-bot2 for Steven Rostedt (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214085206.GW3040@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®