From: Mark Rutland <mark.rutland@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
James Morse <james.morse@arm.com>
Subject: Re: arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler'
Date: Mon, 14 Dec 2020 11:12:25 +0000 [thread overview]
Message-ID: <20201214111216.GA41558@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20201214102847.GA2475@gaia>
On Mon, Dec 14, 2020 at 10:28:48AM +0000, Catalin Marinas wrote:
> On Mon, Dec 14, 2020 at 03:12:34PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 2c85ebc57b3e1817b6ce1a6b703928e113a90442
> > commit: ed3768db588291ddb5dc794daed12cc751373566 arm64: entry: convert el1_sync to C
> > date: 1 year, 2 months ago
> > config: arm64-randconfig-r021-20201214 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed3768db588291ddb5dc794daed12cc751373566
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout ed3768db588291ddb5dc794daed12cc751373566
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler' [-Wmissing-prototypes]
> > 68 | asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
>
> Do we actually need to fix these? It's asmlinkage and called from
> assembly, it wouldn't understand a prototype anyway.
Given we do this for a few other asmlinkage functions in this area, I'll
spin a patch to add the few missing entry-common.c prototypes to
asm/exception.h for consistency.
It's not strictly necessary, but it's vastly less effort than fighting
the testing systems. ;)
Thanks,
Mark.
prev parent reply other threads:[~2020-12-14 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 7:12 kernel test robot
2020-12-14 10:28 ` Catalin Marinas
2020-12-14 11:12 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214111216.GA41558@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®