From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED58EC4361B for ; Mon, 14 Dec 2020 16:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A78092074B for ; Mon, 14 Dec 2020 16:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439386AbgLNQcd (ORCPT ); Mon, 14 Dec 2020 11:32:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:39340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbgLNQcG (ORCPT ); Mon, 14 Dec 2020 11:32:06 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53A2B2074B; Mon, 14 Dec 2020 16:31:25 +0000 (UTC) Date: Mon, 14 Dec 2020 11:31:23 -0500 From: Steven Rostedt To: Jessica Clarke Cc: Anatoly Pugachev , Linux Kernel list , Sparc kernel list , Ingo Molnar Subject: Re: [sparc64] ftrace: kernel startup-tests unaligned access Message-ID: <20201214113123.0b44e35e@gandalf.local.home> In-Reply-To: <20201214162804.GA27786@Jessicas-MacBook.local> References: <20201214111512.415717ac@gandalf.local.home> <20201214162804.GA27786@Jessicas-MacBook.local> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Dec 2020 16:28:04 +0000 Jessica Clarke wrote: > On Mon, Dec 14, 2020 at 11:15:12AM -0500, Steven Rostedt wrote: > > On Mon, 14 Dec 2020 18:59:02 +0300 > > Anatoly Pugachev wrote: > > > > > Hello! > > > > > > Enabled ftrace startup tests on a sparc64 test VM/LDOM: > > > > > > $ diff -u <(gzip -dc ~/dmesg/config-5.10.0.gz) <(gzip -dc /proc/config.gz) > > > --- /dev/fd/63 2020-12-14 16:19:38.239372599 +0300 > > > +++ /dev/fd/62 2020-12-14 16:19:38.235372433 +0300 > > > @@ -2842,7 +2842,10 @@ > > > # CONFIG_TRACEPOINT_BENCHMARK is not set > > > # CONFIG_RING_BUFFER_BENCHMARK is not set > > > # CONFIG_TRACE_EVAL_MAP_FILE is not set > > > -# CONFIG_FTRACE_STARTUP_TEST is not set > > > +CONFIG_FTRACE_SELFTEST=y > > > +CONFIG_FTRACE_STARTUP_TEST=y > > > +CONFIG_EVENT_TRACE_STARTUP_TEST=y > > > +# CONFIG_EVENT_TRACE_TEST_SYSCALLS is not set > > > # CONFIG_RING_BUFFER_STARTUP_TEST is not set > > > # CONFIG_PREEMPTIRQ_DELAY_TEST is not set > > > # CONFIG_KPROBE_EVENT_GEN_TEST is not set > > > > > > > > > Got the following results with kernel boot logs: > > > > > > Dec 14 13:48:15 kernel: clocksource: jiffies: mask: 0xffffffff > > > max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns > > > Dec 14 13:48:15 kernel: futex hash table entries: 65536 (order: 9, > > > 4194304 bytes, linear) > > > Dec 14 13:48:15 kernel: Running postponed tracer tests: > > > Dec 14 13:48:15 kernel: Testing tracer function: > > > Dec 14 13:48:15 kernel: Kernel unaligned access at TPC[552a20] > > > trace_function+0x40/0x140 > > > Dec 14 13:48:15 kernel: Kernel unaligned access at TPC[552a24] > > > trace_function+0x44/0x140 > > > Dec 14 13:48:15 kernel: Kernel unaligned access at TPC[552a20] > > > trace_function+0x40/0x140 > > > Dec 14 13:48:15 kernel: Kernel unaligned access at TPC[552a24] > > > trace_function+0x44/0x140 > > > Dec 14 13:48:15 kernel: Kernel unaligned access at TPC[552a20] > > > trace_function+0x40/0x140 > > > > Does sparc64 require 8 byte alignment for 8 byte words? > > Yes, SPARC requires natural alignment for all primitive types (and that > even includes 8-byte alignment for 8-byte types on 32-bit SPARC as it > has load/store pair instructions the compiler is free to use). > > OK, that means I was misinformed about reverting the patch that forced alignment (and the patch I posted in reply to my email, is the revert of the revert). If the patch I just posted works, then I'll get it ready for mainline and stable. Thanks! -- Steve