From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C54DFC2BB40 for ; Mon, 14 Dec 2020 19:12:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B998221EF for ; Mon, 14 Dec 2020 19:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502440AbgLNTLz (ORCPT ); Mon, 14 Dec 2020 14:11:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54136 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408589AbgLNTH4 (ORCPT ); Mon, 14 Dec 2020 14:07:56 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kotBR-00BxLM-Gj; Mon, 14 Dec 2020 20:06:57 +0100 Date: Mon, 14 Dec 2020 20:06:57 +0100 From: Andrew Lunn To: Divya Koppera Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, marex@denx.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v2 net-next] net: phy: mchp: Add 1588 support for LAN8814 Quad PHY Message-ID: <20201214190657.GB2846647@lunn.ch> References: <20201214175658.11138-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201214175658.11138-1-Divya.Koppera@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int lan8814_read_page_reg(struct phy_device *phydev, > + int page, u32 addr) > +{ > + u32 data; > + > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_CONTROL, page); > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA, addr); > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_CONTROL, (page | 0x4000)); > + data = phy_read(phydev, KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA); > + > + return data; > +} > + > +static int lan8814_write_page_reg(struct phy_device *phydev, > + int page, u16 addr, u16 val) > +{ > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_CONTROL, page); > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA, addr); > + phy_write(phydev, KSZ_EXT_PAGE_ACCESS_CONTROL, (page | 0x4000)); > + val = phy_write(phydev, KSZ_EXT_PAGE_ACCESS_ADDRESS_DATA, val); > + if (val != 0) { > + phydev_err(phydev, "Error: phy_write_mmd has returned error %d\n", > + val); > + return val; > + } > + return 0; > +} I think you can just use phy_read_mmd() and phy_write_mmd(). Andrew