From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBCEC19425 for ; Tue, 15 Dec 2020 05:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A016C2228A for ; Tue, 15 Dec 2020 05:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725957AbgLOFUX (ORCPT ); Tue, 15 Dec 2020 00:20:23 -0500 Received: from mga06.intel.com ([134.134.136.31]:36810 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgLOFUH (ORCPT ); Tue, 15 Dec 2020 00:20:07 -0500 IronPort-SDR: /TJ+ZNnog8bH/TvfCAPsLKwqf/6ssiGsMacf/9mm2bY1SgvU7paSgBIY8IDkkBV9zA2LEEn1O6 HBFQfo6QIWxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="236412676" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="236412676" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 21:19:26 -0800 IronPort-SDR: aXuzYJO+sEpdxJj5Xhf6lsbTjN6bv6yNVel6E8yTR8m1EogcqZ7B6Fxv8hwUw+0Qteh8hiCy8o j3n2bL8zQNFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="368005501" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by orsmga008.jf.intel.com with ESMTP; 14 Dec 2020 21:19:24 -0800 Date: Tue, 15 Dec 2020 13:15:09 +0800 From: Xu Yilun To: Tom Rix Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, lgoncalv@redhat.com, hao.wu@intel.com Subject: Re: [PATCH v2 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Message-ID: <20201215051509.GD14854@yilunxu-OptiPlex-7050> References: <1607916981-14782-1-git-send-email-yilun.xu@intel.com> <1607916981-14782-3-git-send-email-yilun.xu@intel.com> <4bbaa5ad-b0eb-8ea6-9dc6-c08060450e36@redhat.com> <20201215022206.GC14854@yilunxu-OptiPlex-7050> <97d06583-ca99-67ae-55e1-ff714b47f8cb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97d06583-ca99-67ae-55e1-ff714b47f8cb@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2020 at 08:43:31PM -0800, Tom Rix wrote: > > On 12/14/20 6:22 PM, Xu Yilun wrote: > > On Mon, Dec 14, 2020 at 02:14:56PM -0800, Tom Rix wrote: > >> On 12/13/20 7:36 PM, Xu Yilun wrote: > >>> This patch adds description for UIO support for dfl devices on DFL > >>> bus. > >>> > >>> Signed-off-by: Xu Yilun > >>> --- > >>> v2: no doc in v1, add it for v2. > >>> --- > >> > >>> +components. They could instantiate a new private feature in the DFL, and then > >>> +get a DFL device in their system. In some cases users may need a userspace > >>> +driver for the DFL device: > >>> + > >>> +* Users may need to run some diagnostic test for their hardwares. > >> * Users may prototype the kernel driver in user space. > > Could we just add the line rather than replacing the previous line? I think this > > comment is describing a different usecase. > > Yes, this is what i ment, please use your original. > > I am offering another usecase, one I will use. > > Add mine as well, if you want. I'll add your usecase. > > > > >>> +* Some hardware is designed for specific purposes and does not fit into one of > >>> + the standard kernel subsystems. > >>> + > >>> +This requires the direct access to the MMIO space and interrupt handling in > >>> +userspace. We implemented a dfl-uio-pdev module which exposes the UIO device > >> The dfl-uio-pdev module exposes > > Will change it. > > > >>> +interfaces. It adds the uio_pdrv_genirq platform device with the resources of > >>> +the DFL device, and let the generic UIO platform device driver provide UIO > >> the DLF device, and lets > > Will change it. > > > >>> +support to userspace. > >> Use FPGA_DFL_UIO_PDEV to enable this feature. > > I didn't get your idea for this. > > I wanted the user to know which kconfig controls this feature. Understood. I'll add it. Thanks, Yilun