From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5950C2BB9A for ; Tue, 15 Dec 2020 08:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7165420771 for ; Tue, 15 Dec 2020 08:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbgLOIor (ORCPT ); Tue, 15 Dec 2020 03:44:47 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:23736 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727189AbgLOIoR (ORCPT ); Tue, 15 Dec 2020 03:44:17 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0BF8WGpj113404; Tue, 15 Dec 2020 03:43:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : reply-to : references : mime-version : content-type : in-reply-to; s=pp1; bh=Vgrd4a6ftmSkBvlsBVfKg8x23xexkm6P/Ge+WC8gc4Q=; b=Fttn8POBowSfKEfj9sbiOP3HIhjdmQm0aUwfWoUeT5p4nzsVvfTcy/25zRNEwEhMzHnh JHXhAZxjzX+wEK9vUsDNT/I6sgq+wiMCOYM5Md7hh+tIkp9L1/u0p985sFYzt7lruD3b kukDBVapH/v3fQLT5/MMIQ2sDbdrIIYmpqkWeWl3pXLcN82g2p+ZLz8bKKA0XESlPM/j kJl8SwnTDC11bos3t8Bzx1SsiQJCHtfJB5NCrXkucx1trduHMPxBhscP5cDyJBNIZ/wW unwlNcsQE1+EHKNLSdSSgwKiAlgxHrsrol7RDtIC0wl2ZS+0i32LcsFhUXjKFDI61ji6 3A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 35erc6thjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Dec 2020 03:43:20 -0500 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0BF8WO5b114106; Tue, 15 Dec 2020 03:43:20 -0500 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 35erc6thj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Dec 2020 03:43:20 -0500 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0BF8hIS4001247; Tue, 15 Dec 2020 08:43:18 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma03fra.de.ibm.com with ESMTP id 35cng8cgq4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Dec 2020 08:43:17 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0BF8hFai20250962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Dec 2020 08:43:15 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 90D734204C; Tue, 15 Dec 2020 08:43:15 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7384F42041; Tue, 15 Dec 2020 08:43:13 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.126.150.29]) by d06av24.portsmouth.uk.ibm.com (Postfix) with SMTP; Tue, 15 Dec 2020 08:43:13 +0000 (GMT) Date: Tue, 15 Dec 2020 14:13:12 +0530 From: Srikar Dronamraju To: "Gautham R. Shenoy" Cc: Anton Blanchard , Vaidyanathan Srinivasan , Michael Ellerman , Michael Neuling , Nicholas Piggin , Nathan Lynch , Peter Zijlstra , Valentin Schneider , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] powerpc/smp: Rename init_thread_group_l1_cache_map() to make it generic Message-ID: <20201215084312.GC1239129@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <1607596739-32439-1-git-send-email-ego@linux.vnet.ibm.com> <1607596739-32439-4-git-send-email-ego@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1607596739-32439-4-git-send-email-ego@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-15_04:2020-12-11,2020-12-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 mlxlogscore=863 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150055 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Gautham R. Shenoy [2020-12-10 16:08:57]: > From: "Gautham R. Shenoy" > > init_thread_group_l1_cache_map() initializes the per-cpu cpumask > thread_group_l1_cache_map with the core-siblings which share L1 cache > with the CPU. Make this function generic to the cache-property (L1 or > L2) and update a suitable mask. This is a preparatory patch for the > next patch where we will introduce discovery of thread-groups that > share L2-cache. > > No functional change. > Looks good to me. Reviewed-by: Srikar Dronamraju > Signed-off-by: Gautham R. Shenoy -- Thanks and Regards Srikar Dronamraju