From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A9307C4361B
	for <linux-kernel@archiver.kernel.org>; Thu, 17 Dec 2020 02:23:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5A99A23718
	for <linux-kernel@archiver.kernel.org>; Thu, 17 Dec 2020 02:23:58 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728013AbgLQCX5 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 16 Dec 2020 21:23:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37714 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727090AbgLQCX5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Dec 2020 21:23:57 -0500
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B62BC06179C
        for <linux-kernel@vger.kernel.org>; Wed, 16 Dec 2020 18:23:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=8uHs/UhveALE70R5Z9Kg2unr079LnQrGmTT2HTgImw8=; b=FifsAiB3tLiNJPag7q9n8RFM5/
        pk9gX7tAuQJSETnc6fT6mFCRtrmN3ucHavM6Xn8K8jvyvhnvox/5tUNajqntYzSL73VRjnutHSRRk
        dg0m/5QJ/CJcdVCoEACAjAX3L9w7x9cRok3++Zkax/N3DQyOXMOpcTvBbBge9izlvqW24uQ44vqfr
        vpuHGZ3P7SpVuUwaPvWYf7AeNS8XyAOn56x/x3kdr+t425vgJ7xisdFmaqVU2J/TG5SNkqDKR6v8/
        jx9NgNK9WY7uHm/XaZ0DfFvzk8y0+YmPCU6UFT3tq1q1fdx+IDleU30BRZ+07RmdqXv6xHstJJrwM
        WhSosgcw==;
Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kpiwc-0007Ne-NI; Thu, 17 Dec 2020 02:23:06 +0000
Date:   Thu, 17 Dec 2020 02:23:06 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Xiangyang Yu <yuxiangyang4@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype
Message-ID: <20201217022306.GB15600@casper.infradead.org>
References: <20201217020311.491799-1-yuxiangyang4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201217020311.491799-1-yuxiangyang4@huawei.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote:
> Fixed the warning when building with warnings enabled (W=1),
> This function is only used in filemap.c, so mark this function
> with 'static'.

Good grief, no.  Look at the git history before proposing a patch.