mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yanjun Zhang <zhang.yanjuna@h3c.com>
To: <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Yanjun Zhang <zhang.yanjuna@h3c.com>
Subject: [PATCH] writeback: add warning messages for not registered bdi
Date: Thu, 17 Dec 2020 19:28:01 +0800	[thread overview]
Message-ID: <20201217112801.22421-1-zhang.yanjuna@h3c.com> (raw)

The device name is only printed for the warning case, that bdi is not
registered detected by the function __mark_inode_dirty. Besides, the
device name returned by bdi_dev_name may be "(unknown)" in some cases.

This patch add printed messages about the inode and super block. Once
trigging this warning, we could make more direct analysis.

Signed-off-by: Yanjun Zhang <zhang.yanjuna@h3c.com>
---
 fs/fs-writeback.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index e6005c78b..825160cf4 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2323,7 +2323,8 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 
 			WARN((wb->bdi->capabilities & BDI_CAP_WRITEBACK) &&
 			     !test_bit(WB_registered, &wb->state),
-			     "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
+			     "bdi-%s not registered, dirtied inode %lu on %s\n",
+			     bdi_dev_name(wb->bdi), inode->i_ino, sb->s_id);
 
 			inode->dirtied_when = jiffies;
 			if (dirtytime)
-- 
2.17.1


             reply	other threads:[~2020-12-17 11:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 11:28 Yanjun Zhang [this message]
2020-12-22 17:59 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217112801.22421-1-zhang.yanjuna@h3c.com \
    --to=zhang.yanjuna@h3c.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®