From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>,
msavaliy@qti.qualcomm.com, akashast@codeaurora.org,
Roja Rani Yarubandi <rojay@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 3/4] spi: spi-geni-qcom: Don't try to set CS if an xfer is pending
Date: Thu, 17 Dec 2020 13:25:03 +0000 [thread overview]
Message-ID: <20201217132503.GC4708@sirena.org.uk> (raw)
In-Reply-To: <160817911850.1580929.16402785505110078436@swboyd.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On Wed, Dec 16, 2020 at 08:25:18PM -0800, Stephen Boyd wrote:
> > spin_lock_irq(&mas->lock);
> > + if (mas->cur_xfer) {
>
> How is it possible that cs change happens when cur_xfer is non-NULL?
We will set the initial chip select state during controller setup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-17 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 22:41 [PATCH v2 1/4] spi: spi-geni-qcom: Fix geni_spi_isr() NULL dereference in timeout case Douglas Anderson
2020-12-16 22:41 ` [PATCH v2 2/4] spi: spi-geni-qcom: Fail new xfers if xfer/cancel/abort pending Douglas Anderson
2020-12-17 4:21 ` Stephen Boyd
2020-12-17 21:45 ` Doug Anderson
2020-12-18 2:53 ` Stephen Boyd
2020-12-16 22:41 ` [PATCH v2 3/4] spi: spi-geni-qcom: Don't try to set CS if an xfer is pending Douglas Anderson
2020-12-17 4:25 ` Stephen Boyd
2020-12-17 13:25 ` Mark Brown [this message]
2020-12-17 21:21 ` Doug Anderson
2020-12-17 4:29 ` Stephen Boyd
2020-12-17 21:35 ` Doug Anderson
2020-12-18 2:51 ` Stephen Boyd
2020-12-16 22:41 ` [PATCH v2 4/4] spi: spi-geni-qcom: Print an error when we timeout setting the CS Douglas Anderson
2020-12-17 3:41 ` [PATCH v2 1/4] spi: spi-geni-qcom: Fix geni_spi_isr() NULL dereference in timeout case Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217132503.GC4708@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=rojay@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®