Return-Path: Received: from localhost ([103.248.31.152]) by smtp.gmail.com with ESMTPSA id f9sm16893958pfa.41.2020.12.21.08.00.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 08:00:19 -0800 (PST) Date: Mon, 21 Dec 2020 21:30:13 +0530 From: Amey Narkhede To: Markus Elfring Subject: Re: [PATCH] block: aoe: Use seq_putc() if possible Message-ID: <20201221160013.pohxcqob35pk44k6@archlinux> References: <20201220152829.65094-1-ameynarkhede03@gmail.com> <2580003e-91eb-65b0-2a96-7d6fddf3f706@web.de> Content-Disposition: inline In-Reply-To: <2580003e-91eb-65b0-2a96-7d6fddf3f706@web.de> X-TUID: 7yALrRi0EZU+ MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 On 20/12/21 04:04PM, Markus Elfring wrote: > > This is a single character that is printed out. Use seq_putc() for > > it to simplify the code. > > How do you think about to reconsider the integration of a previous update suggestion once more? > > [PATCH 1/3] block-aoe: Use seq_putc() in aoedisk_debugfs_show() > https://lore.kernel.org/lkml/58b532fc-14c5-6e87-75d0-d78703b289dc@users.sourceforge.net/ > https://lore.kernel.org/patchwork/patch/785968/ > https://lkml.org/lkml/2017/5/8/90 > > Regards, > Markus Apologies. I didn't find those patches. I'm a beginner so I'm submitting style changes mainly to get familiar with email based workflow of linux kernel. I'll keep in mind to search previous patches next time before submitting a patch. Amey