mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Alexander Guril <alexander.guril02@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kernel: Fixed two bracket problems in fork.c
Date: Mon, 21 Dec 2020 19:42:04 +0100	[thread overview]
Message-ID: <20201221184204.3xq4qgn5z4nnfk5e@wittgenstein> (raw)
In-Reply-To: <20201221150502.70290-1-alexander.guril02@gmail.com>

On Mon, Dec 21, 2020 at 04:05:02PM +0100, Alexander Guril wrote:
> This fixes two bracket problems in kernel/fork.c
> 
> Signed-off-by: Alexander Guril <alexander.guril02@gmail.com>
> ---

Thanks for the patch.
Unfortunately, there's no real rationale for the change in the commit
message. You probably want to mention that our coding-style mandates
that we don't use {} around single-line statements.

Christian

>  kernel/fork.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 41906a52a764..3a5301867297 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -819,9 +819,8 @@ void __init fork_init(void)
>  	init_task.signal->rlim[RLIMIT_SIGPENDING] =
>  		init_task.signal->rlim[RLIMIT_NPROC];
>  
> -	for (i = 0; i < UCOUNT_COUNTS; i++) {
> +	for (i = 0; i < UCOUNT_COUNTS; i++)
>  		init_user_ns.ucount_max[i] = max_threads/2;
> -	}
>  
>  #ifdef CONFIG_VMAP_STACK
>  	cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "fork:vm_stack_cache",
> @@ -1654,9 +1653,8 @@ static inline void init_task_pid_links(struct task_struct *task)
>  {
>  	enum pid_type type;
>  
> -	for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type) {
> +	for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type)
>  		INIT_HLIST_NODE(&task->pid_links[type]);
> -	}
>  }
>  
>  static inline void
> -- 
> 2.29.2
> 

      reply	other threads:[~2020-12-21 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 15:05 Alexander Guril
2020-12-21 18:42 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201221184204.3xq4qgn5z4nnfk5e@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.guril02@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®