From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44C2CC4360C for ; Wed, 23 Dec 2020 02:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2385122D73 for ; Wed, 23 Dec 2020 02:50:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731195AbgLWCuM (ORCPT ); Tue, 22 Dec 2020 21:50:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:51014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729520AbgLWCV6 (ORCPT ); Tue, 22 Dec 2020 21:21:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 35622225AA; Wed, 23 Dec 2020 02:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608690077; bh=1Z2xeE+FnzBDMyXOFEAoZYKo8qjmxghSfR+XpgDDBdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=enDZRBW8CulfSkgZVwkGy2VOT09GG1hDx1f4PKuPS1nSxjwW78ojZmt1tB5qJIQcI yH1/tqSRjicZU8omuNtsZB3EUiBuOQW3Yh1biwuGe8FSuFhO67DfLJ/o+aTNaFnLzf 45JBvDT09jzEd70saF09ebvRmpY+AU6OyohuSzs8B5kPZvWo/cIDZc/V4oTO942NSl oQ+qlON1BH+YOuz5ojbhlcAHfx+/caPbdq3XJmXMcCYitLMjsf53ztYK+YQ+HZ8VXL ElPPfVeL0W9MAErHi0PvBeXKSsJdt0fRJ1+DZMgpSkVEmUh1RjymJRGIgSrAao5ssM FvmcBKrYUA7EQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qinglang Miao , Thomas Bogendoerfer , Sasha Levin , linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 11/87] mips: cm: add missing iounmap() on error in mips_cm_probe() Date: Tue, 22 Dec 2020 21:19:47 -0500 Message-Id: <20201223022103.2792705-11-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201223022103.2792705-1-sashal@kernel.org> References: <20201223022103.2792705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinglang Miao [ Upstream commit 2673ecf9586551c5bcee499c1cc1949f6f7cc9a1 ] Add the missing iounmap() of iounmap(mips_gcr_base) before return from mips_cm_probe() in the error handling case. Signed-off-by: Qinglang Miao Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/kernel/mips-cm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c index 50d3d74001cbe..aedd353b9b925 100644 --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -228,6 +228,7 @@ int mips_cm_probe(void) if ((base_reg & CM_GCR_BASE_GCRBASE) != addr) { pr_err("GCRs appear to have been moved (expected them at 0x%08lx)!\n", (unsigned long)addr); + iounmap(mips_gcr_base); mips_gcr_base = NULL; return -ENODEV; } -- 2.27.0