From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3988C4332B for ; Wed, 23 Dec 2020 02:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C80F52253D for ; Wed, 23 Dec 2020 02:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729888AbgLWCre (ORCPT ); Tue, 22 Dec 2020 21:47:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:51404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729624AbgLWCWU (ORCPT ); Tue, 22 Dec 2020 21:22:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B97C723159; Wed, 23 Dec 2020 02:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608690099; bh=ST061G8MW2LBbseYmREPujE3LibuuL27qmDShgwhKoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t2J4tuoOee2mrYMXjfqi+q/XzR15fOSFIMYHwV5CvrfNsG/wgv4Iqh+xnalqRlxsq ZjuV6cW8AzWKz+4EipFmQQK9UT7VxkhFuoi4tLp9/H2mCYcNrcvADI1hqEJwCXdUmr oaslTEO3RfXjWJLt8ltb01ZUtCQLvRShFt2ZlQhmdDQaVWFzudaYC7lMH9Mi5B4ghs EAlR3y/U3DjFwjqjbyxyjCw+aKdSPQpwMQSTrYYF3d+tXKwAX9/ZwhmYREvkD3nnn3 LAfnrZ4ptfVbslZdzS2LH8i5RF4ETOMYm2lotAMnaZeGAmdHiEvEPp2t8XAfdN61MW VVVUsgvnz3fCg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Jan=20H=C3=B6ppner?= , Stefan Haberland , Cornelia Huck , Jens Axboe , Sasha Levin , linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 29/87] s390/dasd: Fix operational path inconsistency Date: Tue, 22 Dec 2020 21:20:05 -0500 Message-Id: <20201223022103.2792705-29-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201223022103.2792705-1-sashal@kernel.org> References: <20201223022103.2792705-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Höppner [ Upstream commit 9e34c8ba91697cb7441805c36d92ab3e695df6e0 ] During online processing and setting up a DASD device, the configuration data for operational paths is read and validated two times (dasd_eckd_read_conf()). The first time to provide information that are necessary for the LCU setup. A second time after the LCU setup as a device might report different configuration data then. When the configuration setup for each operational path is being validated, an initial call to dasd_eckd_clear_conf_data() is issued. This call wipes all previously available configuration data and path information for each path. However, the operational path mask is not updated during this process. As a result, the stored operational path mask might no longer correspond to the operational paths mask reported by the CIO layer, as several paths might be gone between the two dasd_eckd_read_conf() calls. This inconsistency leads to more severe issues in later path handling changes. Fix this by removing the channel paths from the operational path mask during the dasd_eckd_clear_conf_data() call. Signed-off-by: Jan Höppner Signed-off-by: Stefan Haberland Reviewed-by: Stefan Haberland Reviewed-by: Cornelia Huck Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/s390/block/dasd_eckd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c index a2e34c853ca98..a801ee11843c3 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -981,6 +981,7 @@ static void dasd_eckd_clear_conf_data(struct dasd_device *device) device->path[i].cssid = 0; device->path[i].ssid = 0; device->path[i].chpid = 0; + dasd_path_notoper(device, i); } } -- 2.27.0