From: Qiujun Huang <hqjagain@gmail.com>
To: rostedt@goodmis.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: Qiujun Huang <hqjagain@gmail.com>
Subject: [PATCH] trace: Remove get/put_cpu() from function_trace_init
Date: Fri, 25 Dec 2020 22:23:47 +0800 [thread overview]
Message-ID: <20201225142347.27204-1-hqjagain@gmail.com> (raw)
Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before
tracer->init()"), get/put_cpu() are not needed anymore.
We can use smp_processor_id() instead.
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
kernel/trace/trace_functions.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
index c5095dd28e20..e36fbb935017 100644
--- a/kernel/trace/trace_functions.c
+++ b/kernel/trace/trace_functions.c
@@ -106,8 +106,7 @@ static int function_trace_init(struct trace_array *tr)
ftrace_init_array_ops(tr, func);
- tr->array_buffer.cpu = get_cpu();
- put_cpu();
+ tr->array_buffer.cpu = smp_processor_id();
tracing_start_cmdline_record();
tracing_start_function_trace(tr);
--
2.17.1
next reply other threads:[~2020-12-25 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 14:23 Qiujun Huang [this message]
2020-12-30 7:46 ` [trace] 2158a32526: BUG:using_smp_processor_id()in_preemptible kernel test robot
2020-12-30 13:30 ` [PATCH] trace: Remove get/put_cpu() from function_trace_init Qiujun Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201225142347.27204-1-hqjagain@gmail.com \
--to=hqjagain@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome