From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jussi Kivilinna <jussi.kivilinna@iki.fi>,
Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable <stable@vger.kernel.org>,
lwn@lwn.net, Jiri Slaby <jslaby@suse.cz>
Subject: Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)
Date: Sun, 27 Dec 2020 21:25:31 +0000 [thread overview]
Message-ID: <20201227212531.GD3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=whF=+EzrxP=3zNMH-1L2Nfs7fNoSufqDwOdRQo5qyMwfw@mail.gmail.com>
On Sun, Dec 27, 2020 at 12:12:00PM -0800, Linus Torvalds wrote:
> On Sun, Dec 27, 2020 at 11:05 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna <jussi.kivilinna@iki.fi> wrote:
> > >
> > > 5.10.3 with patch compiles fine, but does not solve the issue.
> >
> > Duh. adding the read_iter only fixes kernel_read(). For splice, it also needs a
> >
> > .splice_read = generic_file_splice_read,
> >
> > in the file operations, something like this...
>
> Ok, I verified that patch with the test-case in the bugzilla, and it
> seems trivially fine.
>
> So it's committed as 14e3e989f6a5 ("proc mountinfo: make splice
> available again") now.
Is there any point in not doing the same (scripted, obviously) for
all instances with .read == seq_read? IIRC, Christoph even posted
something along those lines, but it went nowhere for some reason...
next prev parent reply other threads:[~2020-12-27 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 15:20 Linux 5.10.3 Greg Kroah-Hartman
2020-12-26 15:20 ` Greg Kroah-Hartman
2020-12-27 16:32 ` LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3) Jussi Kivilinna
2020-12-27 16:56 ` Greg Kroah-Hartman
2020-12-27 17:20 ` Linus Torvalds
2020-12-27 18:39 ` Jussi Kivilinna
2020-12-27 19:05 ` Linus Torvalds
2020-12-27 20:12 ` Linus Torvalds
2020-12-27 21:25 ` Al Viro [this message]
2020-12-27 23:14 ` Linus Torvalds
2020-12-27 21:07 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201227212531.GD3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jslaby@suse.cz \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome