From: Mark Brown <broonie@kernel.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: linux-spi@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com,
hao.wu@intel.com, matthew.gerlach@linux.intel.com,
russell.h.weight@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time
Date: Wed, 30 Dec 2020 13:46:44 +0000 [thread overview]
Message-ID: <20201230134644.GE4428@sirena.org.uk> (raw)
In-Reply-To: <20201230022420.GF14854@yilunxu-OptiPlex-7050>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Wed, Dec 30, 2020 at 10:24:20AM +0800, Xu Yilun wrote:
> On Tue, Dec 29, 2020 at 01:13:08PM +0000, Mark Brown wrote:
> > Does this still apply with current code? There have been some fixes in
> > this area which I think should ensure that we don't turn the speed down
> > to 0 if the controller doesn't supply a limit IIRC.
> Yes, there is chance the speed is set to 0, some related code from 5.11-rc1
Please check the code in the SPI tree and -next.
> BTW, Could we keep the spi->max_speed_hz if no controller->max_speed_hz?
> Always clamp the spi->max_speed_hz to 0 makes no sense.
Right, that's the fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-30 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 5:27 [PATCH 0/2] fix the issue when xfer by spi-altera Xu Yilun
2020-12-29 5:27 ` [PATCH 1/2] spi: altera: fix return value for altera_spi_txrx() Xu Yilun
2020-12-29 5:27 ` [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time Xu Yilun
2020-12-29 13:13 ` Mark Brown
2020-12-30 2:24 ` Xu Yilun
2020-12-30 13:46 ` Mark Brown [this message]
2020-12-31 3:23 ` Xu Yilun
2020-12-31 13:36 ` Mark Brown
2020-12-29 14:33 ` (subset) [PATCH 0/2] fix the issue when xfer by spi-altera Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230134644.GE4428@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®