From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3087C433DB for ; Wed, 30 Dec 2020 18:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A212422262 for ; Wed, 30 Dec 2020 18:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbgL3Sn0 (ORCPT ); Wed, 30 Dec 2020 13:43:26 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:53660 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgL3SnZ (ORCPT ); Wed, 30 Dec 2020 13:43:25 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2D0DA1C0B79; Wed, 30 Dec 2020 19:42:43 +0100 (CET) Date: Wed, 30 Dec 2020 19:42:42 +0100 From: Pavel Machek To: Andrea Righi Cc: Boqun Feng , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: trigger: fix potential deadlock with libata Message-ID: <20201230184242.GA25903@duo.ucw.cz> References: <20201125151822.GB73489@xps-13-7390> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline In-Reply-To: <20201125151822.GB73489@xps-13-7390> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Apply the same change to led_trigger_blink_setup() as well, since the > same deadlock scenario can also happen in power_supply_update_bat_leds() > -> led_trigger_blink() -> led_trigger_blink_setup() (workqueue context), > and potentially prevent other similar usages. Thanks, applied. Pavel --=20 http://www.livejournal.com/~pavelmachek --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX+zKIgAKCRAw5/Bqldv6 8jTaAKCrKQ7L8oRfkIzzYXZAJO19FZ5m8gCgpVytYIxoeWApCsBdJx5z2G6nqmU= =c1r0 -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn--