From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency
Date: Mon, 4 Jan 2021 14:13:29 +0000 [thread overview]
Message-ID: <20210104141329.GG5645@sirena.org.uk> (raw)
In-Reply-To: <s5hk0ss94kr.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Mon, Jan 04, 2021 at 03:09:24PM +0100, Takashi Iwai wrote:
> IMO, the problem is rather the unconditional calls of
> snd_intel_dsp_driver_probe() in snd-soc-sof-pci and snd-soc-sof-acpi
> drivers. Those calls should be done only if Intel drivers are
> involved. So, wrapping the call with ifdef
> CONFIG_SND_SOC_SOF_INTEL_PCI or CONFIG_SND_SOC_SOF_INTEL_ACPI would
> work better (although those are a bit uglier).
Or stubbing them which might be neater.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-04 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 13:52 Arnd Bergmann
2021-01-04 14:09 ` Takashi Iwai
2021-01-04 14:13 ` Mark Brown [this message]
2021-01-04 15:00 ` Jaroslav Kysela
2021-01-04 15:05 ` Takashi Iwai
2021-01-05 13:43 ` Arnd Bergmann
2021-01-05 15:39 ` Kai Vehmanen
2021-01-05 19:06 ` Arnd Bergmann
2021-01-05 19:07 ` [PATCH] ASoC: SOF: Intel: avoid reverse module dependency Arnd Bergmann
2021-01-06 9:30 ` Arnd Bergmann
2021-01-07 11:45 ` Kai Vehmanen
2021-01-11 19:54 ` Pierre-Louis Bossart
2021-01-12 13:55 ` Takashi Iwai
2021-01-12 20:17 ` [Sound-open-firmware] " Pierre-Louis Bossart
2021-01-12 20:31 ` Arnd Bergmann
2021-01-05 13:30 ` [PATCH] ALSA: hda: fix SND_INTEL_DSP_CONFIG dependency Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104141329.GG5645@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®