From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D869C433DB for ; Wed, 6 Jan 2021 00:01:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC73122D01 for ; Wed, 6 Jan 2021 00:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbhAFABA (ORCPT ); Tue, 5 Jan 2021 19:01:00 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51982 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbhAFAA7 (ORCPT ); Tue, 5 Jan 2021 19:00:59 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id CC0494CE685B7; Tue, 5 Jan 2021 16:00:18 -0800 (PST) Date: Tue, 05 Jan 2021 16:00:18 -0800 (PST) Message-Id: <20210105.160018.901800594374682376.davem@davemloft.net> To: fthain@telegraphics.com.au Cc: kuba@kernel.org, christophe.jaillet@wanadoo.fr, tsbogend@alpha.franken.de, chris@zankel.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths From: David Miller In-Reply-To: <529006a7dcd2cd345c2261d4beae0960880f4828.1609633586.git.fthain@telegraphics.com.au> References: <529006a7dcd2cd345c2261d4beae0960880f4828.1609633586.git.fthain@telegraphics.com.au> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Tue, 05 Jan 2021 16:00:19 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Finn Thain Date: Sun, 03 Jan 2021 11:26:26 +1100 > From: Christophe JAILLET > > A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors(). > > This is correctly freed in the remove function, but not in the error > handling path of the probe function. Fix this by adding the missing > dma_free_coherent() call. > > While at it, rename a label in order to be slightly more informative. > > Cc: Christophe JAILLET > Cc: Thomas Bogendoerfer > Cc: Chris Zankel > References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'") > Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.") > Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update") > Signed-off-by: Christophe JAILLET > Signed-off-by: Finn Thain Applied and queued up for -stable, thanks.