From: Daniel Wagner <dwagner@suse.de>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Jens Axboe <axboe@fb.com>, Hannes Reinecke <hare@suse.de>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: hwmon: fix crash on device teardown
Date: Tue, 5 Jan 2021 10:45:45 +0100 [thread overview]
Message-ID: <20210105094545.3tq7c6ev5yn3bhyi@beryllium.lan> (raw)
In-Reply-To: <20210104210610.hliiupywksawgei3@hyori>
On Mon, Jan 04, 2021 at 06:06:10PM -0300, Enzo Matsumiya wrote:
> @Daniel maybe try tweaking your tests to use a smaller controller
> loss timeout (-l option)? I do this on my tests because the default
> value kicks in about 30min after hot-removal -- i.e. you
> have to actually wait for the timeout to expire to trigger the bug.
As far I can tell, the blktests test I am using will trigger the same
bug. The problem is that the lifetime of hwmon sysfs entry should be
aligned to the lifetime of the nvme sysfs entry. Currently, hwmon's
lifetime is bound to the lifetime of the ctl sysfs entry. When the nvme
entry goes away (and obviously also the underlying device), the hwmon
sysfs entry still references it.
next prev parent reply other threads:[~2021-01-05 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 21:32 Enzo Matsumiya
2020-12-10 4:35 ` Chaitanya Kulkarni
2020-12-30 13:23 ` Daniel Wagner
2020-12-10 15:05 ` Keith Busch
2020-12-11 14:12 ` Hannes Reinecke
2020-12-30 14:38 ` Daniel Wagner
2020-12-30 15:16 ` Daniel Wagner
2020-12-30 15:31 ` Daniel Wagner
2021-01-04 21:06 ` Enzo Matsumiya
2021-01-05 9:45 ` Daniel Wagner [this message]
2021-01-11 16:00 ` Hannes Reinecke
2021-01-11 16:06 ` Christoph Hellwig
2021-01-11 16:18 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105094545.3tq7c6ev5yn3bhyi@beryllium.lan \
--to=dwagner@suse.de \
--cc=axboe@fb.com \
--cc=ematsumiya@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®