From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes
Date: Tue, 5 Jan 2021 14:58:10 +0200 [thread overview]
Message-ID: <20210105125810.GQ11878@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210105093803.5247-1-paul.kocialkowski@bootlin.com>
Hi Paul,
Thanks for the patch.
On Tue, Jan 05, 2021 at 10:38:03AM +0100, Paul Kocialkowski wrote:
> This solves a few minor cosmetic issues picked up by checkpatch for
> the OV5648 and OV8865 drivers.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> drivers/media/i2c/ov5648.c | 2 +-
> drivers/media/i2c/ov8865.c | 7 +++----
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> index 609aa67b54ce..752a2e035c49 100644
> --- a/drivers/media/i2c/ov5648.c
> +++ b/drivers/media/i2c/ov5648.c
> @@ -496,7 +496,7 @@
> container_of(s, struct ov5648_sensor, subdev)
>
> #define ov5648_ctrl_subdev(c) \
> - (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev)
> + (&container_of((c)->handler, struct ov5648_sensor, ctrls.handler)->subdev)
Over 80; please wrap.
>
> /* Data structures */
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index fda5a55979aa..704d75b601e3 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -223,7 +223,6 @@
> #define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)
> #define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0)
>
> -
> #define OV8865_INC_Y_ODD_REG 0x382a
> #define OV8865_INC_Y_ODD(v) ((v) & GENMASK(4, 0))
> #define OV8865_INC_Y_EVEN_REG 0x382b
> @@ -460,7 +459,7 @@
> container_of(s, struct ov8865_sensor, subdev)
>
> #define ov8865_ctrl_subdev(c) \
> - (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev)
> + (&container_of((c)->handler, struct ov8865_sensor, ctrls.handler)->subdev)
Ditto.
>
> /* Data structures */
>
> @@ -1598,8 +1597,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor,
> return ret;
>
> ret = ov8865_update_bits(sensor, OV8865_PCLK_SEL_REG,
> - OV8865_PCLK_SEL_PCLK_DIV_MASK,
> - OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
> + OV8865_PCLK_SEL_PCLK_DIV_MASK,
> + OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div));
> if (ret)
> return ret;
>
> --
> 2.29.2
>
--
Sakari Ailus
prev parent reply other threads:[~2021-01-05 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 9:38 Paul Kocialkowski
2021-01-05 12:58 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105125810.GQ11878@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®