From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE725C433E0 for ; Tue, 5 Jan 2021 10:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BE5220739 for ; Tue, 5 Jan 2021 10:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728754AbhAEKQD (ORCPT ); Tue, 5 Jan 2021 05:16:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:58120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728146AbhAEKQD (ORCPT ); Tue, 5 Jan 2021 05:16:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31D0D20739; Tue, 5 Jan 2021 10:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609841722; bh=c/qWKwU3foC5cslHvysoiyySlD0Q/i38HTpYtr6CjsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NvSDi36KrBi698Ne8DdM1rn5gS+fyI4ZsxqY9MAjB65ykGmmytd/o2lxJ1wDKK1Ny qzXs2anYX2VX8pymMbe8aFcJogD1/tE8EnjXgxZlRlKaP7LN1GYs9GFGogvB4oWZkF CVZcj0ERoKTirFl+wR23+RBKZk8CGYXcnZjogYP5Lb+o/zjrAdzN2t9nzjuBFjvRNH xOYS1gF608aaFef6R3VkbUMyaI7pbiBXEGnYFtYfMG+ZrifWUY/RigSpEh5asECoxV DzIdtkY5U6Uir+58cpf8LkKNYrtYa02AHS6yhBqMDu3Syb2dy6EVRIPp5CD+n1KmLF lrgAeAfWluDqA== Date: Tue, 5 Jan 2021 19:15:18 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: "Naveen N. Rao" , Steven Rostedt , shuah@kernel.org, Subject: Re: [PATCH] selftests/ftrace: Disable multiple_kprobes test on powerpc Message-Id: <20210105191518.fc5e602cb10fb22ef1a2303d@kernel.org> In-Reply-To: <20210105190156.ada6ce0d46d7eada18b9ad76@kernel.org> References: <20210105065730.2634785-1-naveen.n.rao@linux.vnet.ibm.com> <20210105190156.ada6ce0d46d7eada18b9ad76@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jan 2021 19:01:56 +0900 Masami Hiramatsu wrote: > On Tue, 5 Jan 2021 12:27:30 +0530 > "Naveen N. Rao" wrote: > > > Not all symbols are blacklisted on powerpc. Disable multiple_kprobes > > test until that is sorted, so that rest of ftrace and kprobe selftests > > can be run. > > This looks good to me, but could you try to find the functions > which should be blocked from kprobes? > (Usually, the function which are involved in the sw-breakpoint > handling, including locks etc.) Ah, OK. I wonder why CONFIG_KPROBE_EVENTS_ON_NOTRACE=n doesn't help, it was ignored if the arch doesn't support CONFIG_KPROBES_ON_FTRACE. Naveen, could you try to run this test case with following patch on powerpc? diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index b911e9f6d9f5..241a55313476 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -433,7 +433,7 @@ static int disable_trace_kprobe(struct trace_event_call *call, return 0; } -#if defined(CONFIG_KPROBES_ON_FTRACE) && \ +#if defined(CONFIG_FUNCTION_TRACER) && \ !defined(CONFIG_KPROBE_EVENTS_ON_NOTRACE) static bool __within_notrace_func(unsigned long addr) { Of course you need to enable CONFIG_FUNCTION_TRACER=y, but it may pass the test. Thank you, -- Masami Hiramatsu