From: Al Viro <viro@zeniv.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] binfmt_elf: Fix fill_prstatus() call in fill_note_info()
Date: Wed, 6 Jan 2021 13:44:28 +0000 [thread overview]
Message-ID: <20210106134428.GB3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210106075112.1593084-1-geert@linux-m68k.org>
On Wed, Jan 06, 2021 at 08:51:12AM +0100, Geert Uytterhoeven wrote:
> On m68k, which does not define CORE_DUMP_USE_REGSET:
>
> fs/binfmt_elf.c: In function ‘fill_note_info’:
> fs/binfmt_elf.c:2040:20: error: passing argument 1 of ‘fill_prstatus’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 2040 | fill_prstatus(info->prstatus, current, siginfo->si_signo);
> | ~~~~^~~~~~~~~~
> | |
> | struct elf_prstatus *
> fs/binfmt_elf.c:1498:55: note: expected ‘struct elf_prstatus_common *’ but argument is of type ‘struct elf_prstatus *’
> 1498 | static void fill_prstatus(struct elf_prstatus_common *prstatus,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>
> The fill_prstatus() signature was changed, but one caller was not
> updated.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 147d88b334cd5416 ("elf_prstatus: collect the common part (everything before pr_reg) into a struct")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Compile-tested only. Feel free to fold into the original commit.
Thanks, folded and pushed out...
next prev parent reply other threads:[~2021-01-06 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 7:51 Geert Uytterhoeven
2021-01-06 13:44 ` Al Viro [this message]
2021-01-26 5:51 ` [binfmt_elf] d97e11e25d: ltp.DS000.fail kernel test robot
2021-01-26 8:03 ` Geert Uytterhoeven
2021-01-29 8:05 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106134428.GB3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®