mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Sergio Sota <pikaslabs@gmail.com>
Cc: robh+dt@kernel.org, wens@csie.org, jernej.skrabec@siol.net,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback
Date: Wed, 6 Jan 2021 16:47:27 +0100	[thread overview]
Message-ID: <20210106154727.6sljxothf6ofhwyv@gilmour> (raw)
In-Reply-To: <0ab34d17-625b-aee1-b77e-c4a9cdb019d7@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

Hi!

Thanks for your patch

The prefix in your commit title should be ARM: dts: sun5i

It looks like your patch has been wrapped. Make sure you send it through
git send-email, or at least that your mailer don't mangle it.

On Wed, Dec 23, 2020 at 08:58:15PM +0100, Sergio Sota wrote:
> From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
> From: Sergio Sota <pikaslabs@gmail.com>
> Date: Wed, 23 Dec 2020 20:03:55 +0100
> Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
>  fallback
> 
> The A10s/A13 display frontend driver is not implemented
> The A10 has a compatible display frontend driver

You should expand a bit on this one. At the DT level, compatible means
that the entire A13 controller can be driven just like the one found on
the A10, for every feature (including the ones we don't support).

Given that the documentation for it is sparse on the A10, I'm assuming
that you instead tested the current driver and found that it was working
for you. However, it doesn't mean that it's the case for each feature
supported by the controller and thus we can't really make that claim.

We should instead add the support for the A13 compatible in the driver.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-01-06 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 19:58 Sergio Sota
2021-01-06 15:47 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106154727.6sljxothf6ofhwyv@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pikaslabs@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®